8000 test(minimald): T25 — Types only narrow, end to end by minimal-foundry[bot] · Pull Request #3336 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

test(minimald): T25 — Types only narrow, end to end - #3336

Merged
mitodrummer merged 1 commit into
mainfrom
agent/2428-types-only-narrow-end-to-end
Nov 12, 2026
Merged

mitodrummer merged 1 commit into
mainfrom
agent/2428-types-only-narrow-end-to-end

Conversation

@minimal-foundry
Copy link
Copy Markdown
Contributor

T25 — Types only narrow, end to end

slice: S5
kind: integration
covers: none
size: S
est: 40 code, 120 tests
executor: agent
difficulty: routine
model: light
diagnostics: daemon log names both refusals
observability: one span covers both refusals
layers:
- slice:
- crates/minimald/src/box_manager/tests.rs: tests
test: cargo nextest run -p minimald derived_task_type_refused_at_expansion_and_admission
produces: none
consumes: none
proof: declare a Box Type that extends task, and see an entry that breaks its constraints refused at expansion and again at the daemon.
depends on:
- blocked by #2420
- blocked by #2424
- blocked by #2426

Proof

The test declares [box_types.ci] with extends = "task" and two entries that set pty_enabled = true, one flat and one under io. The expander refuses each entry with exit 3 and names the entry, the key and [box_types.ci]. The daemon then receives the unchecked spec and refuses it again with exit 3. It names ci, its root task and the key, and files no record. A type ci-loose that tries to allow pty_enabled = true over task does not resolve (exit 3).

Notes from the agent: The test adds no product code. The expansion check (T23) and the admission check (T24) already exist on this branch. minimald has no direct toml dependency, so the test parses the file with str::parse and lets BoxTypes::from_file infer the table type. Cargo.toml did not change. Diagnostics and observability: the daemon log names both refusals (the flat pty_enabled key and the nested io.pty_enabled key) with exit_code=3, and the create span records refusal= on each line. The expansion refusal runs on the client side, so it is an error value and not a daemon log line. clippy -p minimald --all-targets showed no warning in the test file. Nothing calls check_constraints in the min create path yet (#3295), so the test calls the expander functions directly, as the client will.

Tests

line exit tail
cargo nextest run -p minimald derived_task_type_refused_at_expansion_and_admission 0 warning: unknown fields in task runtime-implement-test-0: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-0 in box runtime-implement-test-0-1... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling args v0.

Verify

min task run agent-verify timed out after 1800s, so this PR is a draft.

ge.com\u{1f}SCCACHE_REGION=auto\u{1f}SCCACHE_S3_USE_SSL=true\u{1f}SHELL=/usr/bin/bash\u{1f}SHLVL=2\u{1f}SSL_CERT_DIR=/etc/ssl/certs\u{1f}SSL_CERT_FILE=/etc/ssl/cert.pem\u{1f}XDG_CACHE_HOME=/state/cache\u{1f}XDG_CONFIG_HOME=/home/.config\u{1f}XDG_DATA_HOME=/home/.local/share\u{1f}XDG_RUNTIME_DIR=/run\u{1f}XDG_STATE_HOME=/home/.local/state\u{1e}stdin\n"
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 3 tests still running
        PASS [   0.344s] ( 600/1487) minimald env::tests::search_finds_known_package
        PASS [   0.710s] ( 601/1487) minimald env::tests::refresh_remaps_the_installed_set_onto_the_new_graph
        SLOW [> 60.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>120.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>180.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>240.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>300.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>360.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>420.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>480.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>540.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>600.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>660.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>720.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>780.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>840.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>900.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>960.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1020.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1080.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1140.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1200.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1260.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1320.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1380.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1440.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task

Closes #2428

An entry of a project type that extends task and breaks its constraint
is refused with exit 3 by the expander, and again by the daemon when
the unchecked spec reaches it. A type that loosens the task root does
not resolve.
@coderabbitai
coderabbitai Bot commented Nov 12, 2026 •
Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b232d340-146d-4ed3-8fc5-b6ab77204318

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@minimal-foundry
minimal-foundry Bot commented Nov 12, 2026 •
Copy link
Copy Markdown
Contributor Author

Approved: no findings at 59ceb3443eed.

Nothing to do.

Verdict APPROVE, posted as a comment: the App cannot review its own pull request; the check and the label carry it.

Clobber: none: the diff only appends to tests.rs.

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

This PR adds one test and no product code. The test proves that a type which extends task only narrows it, as design principle 9 and the Composition rule (line 1264) require. It drives the real loosening check, the expansion check and the daemon admission check. It relaxes none of them. The open client wiring (#3295) and the exit-code transport (#3313) are filed residuals.

Ruled at 59ceb34 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 12, 2026
@mitodrummer mitodrummer left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mitodrummer
mitodrummer added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit 3e4398f Nov 12, 2026
40 checks passed
@mitodrummer
mitodrummer deleted the agent/2428-types-only-narrow-end-to-end branch November 12, 2026 23:54
@bryan-minimal bryan-minimal left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read at 59ceb34, with a lab run.

The test proves both layers refuse, in the right order. Expansion refuses an entry that breaks [box_types.ci]'s pty_enabled = false, flat and under io, with exit 3 and the entry, key and type named; the unchecked spec then reaches the daemon and is refused again with exit 3, naming ci, its root task and the key, with no record filed; and a derived type that widens a constraint (ci-loose) fails to resolve, naming the type, key and parent. That is T23 and T24 exercised together, which is what the task asked, with no product code touched.

Lab, Linux: the full CI mirror (workspace nextest with the new test, the native daemon e2e, clippy, doctests) passes at this tree, and the baseline holds on Ubuntu 24.04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T25 — Types only narrow, end to end

2 participants

0