8000 fix(minimal): T42 — Rename on a native host prints no VM-host warning by minimal-foundry[bot] · Pull Request #3333 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content
10000

fix(minimal): T42 — Rename on a native host prints no VM-host warning - #3333

Merged
mitodrummer merged 1 commit into
mainfrom
agent/3319-rename-on-a-native-host-prints-no-vm-host-warnin
Nov 12, 2026
Merged

mitodrummer merged 1 commit into
mainfrom
agent/3319-rename-on-a-native-host-prints-no-vm-host-warnin

Conversation

@minimal-foundry
Copy link
Copy Markdown
Contributor

T42 — Rename on a native host prints no VM-host warning

slice: S7
kind: task
covers: BCLI-058
size: S
est: 15 code, 45 tests
executor: agent
difficulty: routine
model: standard
diagnostics: none new; the spurious warning goes away
observability: none new
layers:
- client:
- crates/minimal/src/cmd/boxes/vm_host.rs: move_held_box_name withdraws the old host row only where a VM host daemon holds one: with no control socket (a native host) it skips the withdrawal and prints nothing
- crates/minimal/src/tests.rs: the in-process minimald test harness gains this layer's tests
test: cargo nextest run -p minimal box_rename_native_host_prints_no_vm_host_warning
produces: none
consumes: none
proof: min box rename <box> <new> on a native host renames the box and prints no warning; on a VM host it still withdraws the old host row.

Proof

min box rename <box> <new> on a native host renames the box and prints no warning about the VM host daemon. On a VM host, the rename still withdraws the old host row by the box id and moves the name hold.

Notes from the agent: The warning came from minimal_client::box_registration::withdraw_box_row. move_held_box_name called it with no control socket and with the box id. Now move_held_box_name returns early when there is no control socket. The hold and release calls after it were already silent without a socket. The new test failed before the fix, with that exact warning in the log. The existing VM-host test a_rename_retires_nothing_and_a_stop_retires_as_stopped still passes, and it shows the withdraw, release and hold requests. cargo clippy -p minimal --all-targets and cargo fmt --check reported nothing. I did not run just ci.

Tests

line exit tail
cargo nextest run -p minimal box_rename_native_host_prints_no_vm_host_warning 0 warning: unknown fields in task runtime-implement-test-0: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-0 in box runtime-implement-test-0-1... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling args v0.

Verify

min task run agent-verify exited 100, so this PR is a draft.

 {
                "parent_span_id": "982386e30f70d0d7",
                "rpc": "minimald-v1-GetSessionRecord",
                "span_id": "909c874fda4e2cce",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "909c874fda4e2cce",
                "queued_behind": "0",
                "span_id": "e337274a3af4a505",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "rpc",
            fields: {
                "parent_span_id": "982386e30f70d0d7",
                "rpc": "minimald-v1-DestroySession",
                "span_id": "410adf290c4a9bbf",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "410adf290c4a9bbf",
                "queued_behind": "0",
                "span_id": "84cbcef8ffe50693",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "410adf290c4a9bbf",
                "queued_behind": "0",
                "span_id": "ef31052acc48f4b8",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "ef31052acc48f4b8",
                "span_id": "ba21d113dedf45f1",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "ef31052acc48f4b8",
                "queued_behind": "0",
                "span_id": "e400d29ebb6bcaa3",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  65.693s] 1098 tests run: 1097 passed, 1 failed, 2 skipped
        FAIL [   2.897s] (1098/1098) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Closes #3319

move_held_box_name withdrew the old host row even with no control
socket, so min box rename on a native host logged a warning about the
VM host daemon. With no control socket it now asks for nothing. A VM
host still withdraws the old row and moves the name hold.
@coderabbitai
coderabbitai Bot commented Nov 12, 2026 •
Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 347a5e06-7415-4b0b-9ebe-44d2db560f6c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@minimal-foundry
minimal-foundry Bot commented Nov 12, 2026 •
Copy link
Copy Markdown
Contributor Author

Reviewed: 1 finding, none blocking at 34d6d621d8a1.

Address the comments on the diff.

Clobber: none seen.

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The change conforms to the design. architecture.md line 487 says that a rename changes only the alias, and the rename path is unchanged. The early return in move_held_box_name removes a spurious warning on a native host. A native host has no VM host daemon, and the sibling helpers already skip silently without a control socket. Note: vm_host_control_sock also returns None on a VM host when the socket does not resolve, so the new doc comment is narrower than the code. The design states no rule for that log, so it is not a condition.

Ruled at 34d6d62 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 2 of 3 personas ran (correctness, security); did not complete: supply-chain.

Comment thread crates/minimal/src/cmd/boxes/vm_host.rs Resolved
@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 1 of 10 on the runtime's review findings: the coder changed nothing. Revise round 1: no code change. The one review thread is invalid, and the reason is in its entry. files_changed lists the files from the earlier commit on this branch.

Review threads the coder judged:

  • 👎 invalid — crates/minimal/src/cmd/boxes/vm_host.rs:250: The premise does not hold for the other callers. session.rs:1063, lifecycle.rs:256 and dash/rpc.rs:705 pass box_addresses and an id only together with them (box_addresses.and(box_id), or the registration). A native box registers no host row, so both are None and withdraw_box_row returns at its (None

@mitodrummer mitodrummer left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mitodrummer
mitodrummer added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit 371e6cf Nov 12, 2026
39 checks passed
@mitodrummer
mitodrummer deleted the agent/3319-rename-on-a-native-host-prints-no-vm-host-warnin branch November 12, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T42 — Rename on a native host prints no VM-host warning

1 participant

0