8000 T53 — A typed session entry starts from its own expanded body and lifetime · Issue #3486 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content
8000

T53 — A typed session entry starts from its own expanded body and lifetime #3486

Open

Description

@agent-137

Task

slice size difficulty model who estimated lines
Start, attach and resume M needs care strongest an agent 420 (220 code, 200 tests)

A typed session entry other than default starts, and its box stores that entry's own expanded body and lifetime, as min box spec <entry> shows them.

Owner decision, 2026-11-16: #3204 and #3458 are one BCLI task.

The fix builds the create's spec from the typed entry's expansion (session_box_expansion, through mfile::expand), as min box spec <entry> does. It removes the [session] body path for a typed entry and the interim refusal, with no fallback.

Covers:

  • BCLI-029
  • BCLI-071

Layers:

  • mfile:
    • crates/mfile/src/spec.rs: BoxSpec::build takes the lifetime from the expanded spec instead of hard-coding until_complete; the spec tests pin both values
    • cargo nextest run -p mfile box_spec_takes_lifetime_from_expansion
  • client:
    • crates/minimal/src/cmd/boxes/create.rs: stamp_session_spec_as builds the create's spec from session_box_expansion for the typed entry, not from [session]; project_bep_and_grants reads that expansion for secrets, env and the Box Egress Proxy; plan_start drops NamedSessionUnsupported and the BCLI: starting a typed session entry carries that entry's body into the stored spec (T10 residual, arch C2) #3204 interim comments
    • crates/minimal/src/tests.rs: tests
    • cargo nextest run -p minimal start_typed_session_entry_stores_its_own_body
    • cargo nextest run -p minimal session_entry_until_stopped_stores_until_stopped

Waits on:

Closes #3204
Closes #3458

Plan block
### T53 — A typed session entry starts from its own expanded body and lifetime
  slice: S3
  kind: task
  covers: BCLI-029, BCLI-071
  size: M
  est: 220 code, 200 tests
  executor: agent
  difficulty: needs care
  model: strongest
  diagnostics: none new; the `NamedSessionUnsupported` refusal is removed, and the tests that pin it move with it
  observability: none new
  layers:
    - mfile:
      - crates/mfile/src/spec.rs: `BoxSpec::build` takes the lifetime from the expanded spec instead of hard-coding `until_complete`; the spec tests pin both values
      test: cargo nextest run -p mfile box_spec_takes_lifetime_from_expansion
    - client:
      - crates/minimal/src/cmd/boxes/create.rs: `stamp_session_spec_as` builds the create's spec from `session_box_expansion` for the typed entry, not from `[session]`; `project_bep_and_grants` reads that expansion for secrets, env and the Box Egress Proxy; `plan_start` drops `NamedSessionUnsupported` and the #3204 interim comments
      - crates/minimal/src/tests.rs: tests
      test: cargo nextest run -p minimal start_typed_session_entry_stores_its_own_body
      test: cargo nextest run -p minimal session_entry_until_stopped_stores_until_stopped
  produces: none
  consumes: T129's stored expanded spec (#3409)
  proof: With `[sessions.dev]` declaring its own packages, secrets and an `on_activate` hook, and `[sessions.dev.box] lifetime = "until_stopped"`, `min session start dev` and `min box start dev` both start the box. Its stored spec names `dev` and carries dev's packages, secrets, hook and `until_stopped`, matching `min box spec dev`, and `min box restart` reaches it.
  depends on:
    - blocked by #3409

Activity

  1. minimal-foundry commented on Nov 16, 2026

    @minimal-foundry
    Contributor

    Refused: consumes: carries "T129's stored expanded spec (#3409)" on its own line; its content belongs on the lines beneath it.

    epic #2879

    Updated 2026-11-16T23:07:31.257Z.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0