8000 mfile: one env var table under one name — fold vars, vars_lenient and the task env_vars together, merging by name · Issue #3469 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

Navigation Menu

mfile: one env var table under one name — fold vars, vars_lenient and the task env_vars together, merging by name #3469

Closed

Description

@msample

Follows the owner ruling on gominimal/arch#177 (2026-11-16).

Today.

  • crates/mfile/src/expand.rs SPEC_KEYS has three variable keys: vars (a table), vars_lenient (a list of { name, value } rows) and env_vars (a table). BOX-180 merges vars and vars_lenient by name (merge_vars, VAR_KEYS). env_vars, which task entries use (docs/reference/tasks.md#env_vars), is still replaced wholesale under BOX-064's general rule.
  • vars_lenient exists only to accept names that are not POSIX-shaped. A TOML table can hold any name Linux accepts, quoted where needed, so one table can hold every variable.
  • The architecture's Box Spec has one variable table, [env_vars] (box.toml in gominimal/arch). feat(mfile): replace the interim SPEC_KEYS table with the full box.toml schema (BOX-076) #3096 will replace SPEC_KEYS with that schema, which has no vars or vars_lenient.

The architecture's rule (gominimal/arch#177). [env_vars] and the env vars a loadout sets merge by variable name at every expansion layer, each type of an extends chain included. Up to and including the entry, the most specific layer wins on a name. A selected loadout only adds names, and a different resolved value fails the expansion with exit 3. The architecture names 8000 no loadout key, so it does not change when this issue lands.

Scope:

  1. One variable table under one name, for every entry type, [defaults], [defaults.<type>], Box Type defaults and loadouts, holding any name Linux accepts. The name must match the Box Spec schema feat(mfile): replace the interim SPEC_KEYS table with the full box.toml schema (BOX-076) #3096 adopts. That schema says env_vars today; if vars is preferred, ask gominimal/arch to rename the box.toml table first.
  2. Merge it by name as BOX-180 says, for tasks too, so a task's variables merge with [defaults] and [defaults.task] once minimal: a task box gets no vars or patches from [defaults] or [defaults.task] #3266 makes them reach the task box.
  3. Retire vars_lenient and whichever of vars and env_vars is not chosen, with a migration path for existing minimal.toml and loadout files.
  4. Retire BOX-184 (a name set twice in one layer), which has no case once a layer has one table. Update spec 29 BOX-048, BOX-064, BOX-167 and BOX-180, docs/reference/minimal-dot-toml.md, docs/reference/loadouts.md and docs/reference/tasks.md.

Refs #3096, #3266, #3300, gominimal/arch#177.


This is a residual of epic #2236 (BOX).

Activity

  1. added
    kind:choreMaintenance, refactor, or internal improvement. Applied by the inbox-route classifier.
    on Nov 16, 2026
  2. agent-137 commented on Nov 16, 2026

    @agent-137
    Member

    Owner decisions of 2026-11-16 for this issue: the one table is env_vars, matching the architecture's [env_vars]. vars and vars_lenient retire. A minimal.toml or loadout file that still uses a retired key fails the expansion with exit 3, and the message names the new key. There is no interim acceptance. The plan is a spec 29 amendment first, then two tasks under S5 (#2371): one for mfile, the client expansion and the docs, one for the boxes loadout parser, the wire types and the daemon composer. #3096 and #3467's item 2 wait on both.

  3. agent-137 commented on Nov 21, 2026

    @agent-137
    Member

    Delivered. #3632 amended spec 29: one env_vars table at every layer (BOX-205), the retired keys refused (BOX-206), POSIX names only (BOX-207). The three tasks are merged: T135 #3662, T136 #3691 and T137 #3683. Spec 28's matching edit is #3631 (BCLI).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind:choreMaintenance, refactor, or internal improvement. Applied by the inbox-route classifier.priority:should-haveShould be done. Applied by the inbox-route classifier or a human.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0