8000 minimal: a task box gets no vars or patches from [defaults] or [defaults.task] · Issue #3266 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

minimal: a task box gets no vars or patches from [defaults] or [defaults.task] #3266

Open

Description

@agent-137

Residual of BOX T21 (#2418, PR #3244), from arch condition C1 (arch_rulings 1127).

A task entry's expanded vars, vars_lenient and patches do not reach its box. box_entry in crates/minimal/src/cmd/boxes/create.rs sends none of them for a task entry (the box_type != boxes::TASK_BOX_TYPE branch). min task run reads vars and patches only from the raw [tasks.<name>] table (declared_task, then mfile::File::task). So a vars or patches key in [defaults] or [defaults.task] never reaches a task box. Both keys are SPEC_KEYS in crates/mfile/src/expand.rs.

The architecture merges [defaults] into every entry (architecture.md line 1204) and [defaults.<type>] into entries of that type (line 1205).

Scope: make run_entry in crates/minimal/src/task.rs take the task's vars, vars_lenient and patches from the expanded task entry. Add a [defaults] vars case and a [defaults.task] patches case to expanded_session_and_task_entries_start_both_boxes.

Not a regression: min task run never read those layers. Refs #2236, #2418, #3244.


This is a residual of epic #2236 (BOX).

Activity

  1. agent-137 commented on Nov 16, 2026

    @agent-137
    MemberAuthor

    The owner ruling of 2026-11-16 on gominimal/arch#177 is the basis for this: environment variables merge by name at every expansion layer, [defaults] and [defaults.<type>] included, so a task box gets them from those layers too. This stays its own issue rather than folding into #3469. This issue is about the task path, which never reads its [defaults] layers, for vars and for patches. #3469 is about the shape of the vars table. If #3469 lands first, this issue delivers its one [env_vars] table. If this lands first, #3469 renames what it delivers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority:should-haveShould be done. Applied by the inbox-route classifier or a human.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0