boxes: drop WireContribution::entry and compose vars, patches and loadout hooks from the stored spec (T129 residual) · Issue #3467 · gominimal/minimal · GitHub
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
boxes: drop WireContribution::entry and compose vars, patches and loadout hooks from the stored spec (T129 residual) #3467
Residual of T129 (#3409, PR #3461), from the arch ruling on 714cfc1 (C2).
T129 makes the daemon store the expanded spec and compose a box's project items from it. Three parts of the move away from the old five-list contribution are not in that PR:
Remove WireContribution::entry and WireBoxEntry from crates/boxes/src/wire/request.rs, which the expanded spec replaces. The layers for this include crates/boxes/src/daemon/composer.rs (compose_entry) and crates/minimal/src/task.rs.
The stored BoxSpec carries vars, vars_lenient and patches, so the daemon reads them from the stored spec, not from the contribution.
The daemon composes loadout hooks from the stored spec's hooks whose declared_by has kind = "loadout", not from the contribution.
Pin each part with a test that composes a box from a stored spec alone and gets the same vars, patches and loadout hooks as the record shows.
Related: #3257 (compose from the stored expanded spec) and #3282 (BOX-179, each hook keeps its declared_by). Neither closes until this work lands, where it tracks the same work.
Ordering with #3469: item 2 here has the stored BoxSpec carry vars and vars_lenient. After #3469 those are one [env_vars] table (owner ruling of 2026-11-16 on gominimal/arch#177). Do #3469 first, or do item 2 here with the one table, so the stored spec is not given two variable fields and then changed again. T129 (#3461) does not add the fields, so it needs no change for this.
Activity
agent-137 commentedon Nov 16, 2026
Ordering with #3469: item 2 here has the stored
BoxSpeccarryvarsandvars_lenient. After #3469 those are one[env_vars]table (owner ruling of 2026-11-16 on gominimal/arch#177). Do #3469 first, or do item 2 here with the one table, so the stored spec is not given two variable fields and then changed again. T129 (#3461) does not add the fields, so it needs no change for this.