8000 boxes: drop WireContribution::entry and compose vars, patches and loadout hooks from the stored spec (T129 residual) · Issue #3467 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

boxes: drop WireContribution::entry and compose vars, patches and loadout hooks from the stored spec (T129 residual) #3467

Open

Description

@agent-137

Residual of T129 (#3409, PR #3461), from the arch ruling on 714cfc1 (C2).

T129 makes the daemon store the expanded spec and compose a box's project items from it. Three parts of the move away from the old five-list contribution are not in that PR:

  1. Remove WireContribution::entry and WireBoxEntry from crates/boxes/src/wire/request.rs, which the expanded spec replaces. The layers for this include crates/boxes/src/daemon/composer.rs (compose_entry) and crates/minimal/src/task.rs.
  2. The stored BoxSpec carries vars, vars_lenient and patches, so the daemon reads them from the stored spec, not from the contribution.
  3. The daemon composes loadout hooks from the stored spec's hooks whose declared_by has kind = "loadout", not from the contribution.

Pin each part with a test that composes a box from a stored spec alone and gets the same vars, patches and loadout hooks as the record shows.

Related: #3257 (compose from the stored expanded spec) and #3282 (BOX-179, each hook keeps its declared_by). Neither closes until this work lands, where it tracks the same work.

Refs #2236.


This is a residual of epic #2236 (BOX).

Activity

  1. agent-137 commented on Nov 16, 2026

    @agent-137
    MemberAuthor

    Ordering with #3469: item 2 here has the stored BoxSpec carry vars and vars_lenient. After #3469 those are one [env_vars] table (owner ruling of 2026-11-16 on gominimal/arch#177). Do #3469 first, or do item 2 here with the one table, so the stored spec is not given two variable fields and then changed again. T129 (#3461) does not add the fields, so it needs no change for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority:nice-to-haveNice to have. Applied by the inbox-route classifier or a human.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0