8000 add a %%shell exit-builtin regression test by copybara-service[bot] · Pull Request #6022 · googlecolab/colabtools · GitHub
[go: up one dir, main page]

Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions tests/system_commands_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,27 @@ def testErrorPropagatesByDefault(self):
self.assertEqual(1, result.returncode)
self.assertEqual('', result.output)

def testExitBuiltinPropagatesByDefault(self):
run_cell_result = self.run_cell(textwrap.dedent("""
import subprocess
try:
%shell exit 1
except subprocess.CalledProcessError as e:
caught_exception = e
"""))
captured_output = run_cell_result.output

self.assertEqual('', captured_output.stderr)
self.assertEqual('', captured_output.stdout)
self.assertIn(
'caught_exception',
self.ip.user_ns,
'the default path must raise CalledProcessError',
)
result = self.ip.user_ns['caught_exception']
self.assertEqual(1, result.returncode)
self.assertEqual('', result.output)

def testIgnoreErrorsDoesNotPropagate(self):
run_cell_result = self.run_cell(
textwrap.dedent(
Expand Down
0