Repository navigation
Drop type parameters from Kotlin generated _MembersInjector classes. - #5357
Merged
Merged
Conversation
In Kotlin codegen, declaring type parameters on generated `_MembersInjector` classes and their static `inject*` methods exposes any non-public, intersection, or self-referencing bounds on the injected class's type parameters in the public signature, causing Kotlin visibility errors when referenced across packages or modules (b/438765237). As part of the Kotlin factory/injector codegen migration, this change removes type parameters from generated Kotlin `_MembersInjector` classes, delegates public `inject*` companion methods on generic types to `private` generic `*Internal<Nothing>` helpers so type parameter bounds remain encapsulated within the injector class, and omits `@JvmStatic` on `private` static functions in `XTypeSpecs`. RELNOTES=N/A PiperOrigin-RevId: 1021216746
copybara-service
Bot
force-pushed
the
test_1014062750
branch
from
November 13, 2026 20:01
7a8d6d4 to
c9a1903
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop type parameters from Kotlin generated
_MembersInjectorclasses.In Kotlin codegen, declaring type parameters on generated
_MembersInjectorclasses and their staticinject*methods exposes any non-public, intersection, or self-referencing bounds on the injected class's type parameters in the public signature, causing Kotlin visibility errors when referenced across packages or modules (b/438765237).As part of the Kotlin factory/injector codegen migration, this change removes type parameters from generated Kotlin
_MembersInjectorclasses, delegates publicinject*companion methods on generic types toprivategeneric*Internal<Nothing>helpers so type parameter bounds remain encapsulated within the injector class, and omits@JvmStaticonprivatestatic functions inXTypeSpecs.RELNOTES=N/A