Repository navigation
Tags
Tags
VFS: fix expansion of symbolic links inside mounts We had a bug processing symbolic links in a filesystem not mounted on /. Since recently, scripts/build runs cpiod.so while the ZFS filesystem is mounted on "/zfs/zfs", not "/", so this bug was exposed, and made "build image=java-tests,openjdk8-fedora", for example, fail, while trying to use a symbolic link which seemed to be set up correctly. The problem was in the namei() function, which among other things expands symbolic links while translating a pathname into a vnode. Internally, namei() separates a full path like /zfs/zfs/usr/lib/jvm/java into a mount point (/zfs/zfs) and node (/usr/lib/jvm/java), and looks up only the node inside the file system. However, the *target* of the symbolic link is in the context of the whole system, not necessarily inside this mountpoint. The code forgot that the full path contains the mountpoint (/zfs/zfs) which node does not, and when the mountpoint wasn't "/", it messed up some calculations, and the result was botched up symbolic link translations, and using the symbolic links inside a path failed. Signed-off-by: Nadav Har'El <nyh@cloudius-systems.com> Signed-off-by: Pekka Enberg <penberg@scylladb.com>
README: fix outdated information The information in README.md about the "img_format" make parameter is outdated. The current build script always builds a qcow2 image, and it can be converted by the scripts/convert script. Signed-off-by: Nadav Har'El <nyh@cloudius-systems.com> Signed-off-by: Avi Kivity <avi@cloudius-systems.com>
PreviousNext