Repository navigation
fix: close seven contract gaps reported by downstream (as-child, Empty frame, Alert variants, SheetPanel, Tabs a11y, Textarea code, sidebar anchor) #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sheepbox8646
wants to merge
8
commits into
main
Choose a base branch
from
fix/design-contract-gaps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e2b682c
fix(button): land th
8000
e as-child contract on the caller's element
sheepbox8646 0796214
fix(empty): draw the frame it always claimed to have
sheepbox8646 75313dc
feat(alert): add success and warning variants
sheepbox8646 c9c9228
feat(sheet): add SheetPanel and SheetBody, the DialogPanel of the drawer
sheepbox8646 69b85b7
fix(tabs): forward aria-* to the element that carries role="tablist"
sheepbox8646 ab48e34
feat(textarea): add variant="code" for machine text
sheepbox8646 4b55df3
fix(sidebar): correct SidebarMenuSub's data-sidebar anchor
sheepbox8646 c9cfaf2
docs(contract): write back the decisions this branch locked
sheepbox8646 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.