Repository navigation
refactor(web): import owner components from @felinic/ui directly, drop the shims - #904
Merged
Merged
Conversation
…p the shims The 26 re-export shims (25 components + useClipboard) were a transition device from the felinics#839 lift — every call site now imports the named export from @felinic/ui, so the shims' job is done. Mechanical rewrite: 306 import sites + 8 test files' vi.mock targets. No behavior change. Closes felinics#862.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #862. Follow-through on #839 (which lifted the settings/form owner vocabulary into
@felinic/uibehind temporary re-export shims).What
@/components/settings/row.vue,@/components/page-shell/index.vue, …) to named imports from@felinic/uicomposables/useClipboard.ts) — net +212/−724vi.mocktargets moved from shim paths to@felinic/uinamed-export stubs (same stub bodies, new host)No behavior change — import-path convergence only.
Verification
vue-tsc --noEmit✅ / eslint ✅ /check-ui-contract✅./nav-item.vueimport inside settings-sidebar, and one test mocking a shim path)chat-list/ desktop failures); zero new failures