8000 refactor(web): import owner components from @felinic/ui directly, drop the shims by qqqqqf-q · Pull Request #904 · felinics/Memoh · GitHub
[go: up one dir, main page]

Skip to content

refactor(web): import owner components from @felinic/ui directly, drop the shims - #904

Merged
qqqqqf-q merged 1 commit into
felinics:mainfrom
qqqqqf-q:refactor/web-drop-ui-shims
Jul 31, 2026
Merged

qqqqqf-q merged 1 commit into
felinics:mainfrom
qqqqqf-q:refactor/web-drop-ui-shims

Conversation

@qqqqqf-q
Copy link
Copy Markdown
Member

Closes #862. Follow-through on #839 (which lifted the settings/form owner vocabulary into @felinic/ui behind temporary re-export shims).

What

  • 306 call sites rewritten from shim paths (@/components/settings/row.vue, @/components/page-shell/index.vue, …) to named imports from @felinic/ui
  • 26 shim files deleted (25 component re-exports + composables/useClipboard.ts) — net +212/−724
  • 8 test files' vi.mock targets moved from shim paths to @felinic/ui named-export stubs (same stub bodies, new host)

No behavior change — import-path convergence only.

Verification

  • vue-tsc --noEmit ✅ / eslint ✅ / check-ui-contract ✅
  • Production build ✅ — caught the two stragglers typecheck couldn't (a relative ./nav-item.vue import inside settings-sidebar, and one test mocking a shim path)
  • Full vitest: 3 files / 54 tests failing, identical to the clean-main baseline (pre-existing chat-list / desktop failures); zero new failures

…p the shims

The 26 re-export shims (25 components + useClipboard) were a transition
device from the felinics#839 lift — every call site now imports the named export
from @felinic/ui, so the shims' job is done. Mechanical rewrite: 306
import sites + 8 test files' vi.mock targets. No behavior change.

Closes felinics#862.
@qqqqqf-q
qqqqqf-q requested a review from a team July 31, 2026 07:36
@qqqqqf-q
qqqqqf-q merged commit d393a89 into felinics:main Jul 31, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(web): migrate call sites to @felinic/ui and delete the re-export shims

1 participant

0