8000 chore(deps): frontend dependency upgrades (minors, ESLint 10, TS 6, vue-router 5, katex, markstream-vue) by qqqqqf-q · Pull Request #870 · felinics/Memoh · GitHub
[go: up one dir, main page]

Skip to content

chore(deps): frontend dependency upgrades (minors, ESLint 10, TS 6, vue-router 5, katex, markstream-vue) - #870

Merged
qqqqqf-q merged 11 commits into
felinics:mainfrom
qqqqqf-q:chore/frontend-dep-upgrades
Jul 29, 2026
Merged

qqqqqf-q merged 11 commits into
felinics:mainfrom
qqqqqf-q:chore/frontend-dep-upgrades

Conversation

@qqqqqf-q
Copy link
Copy Markdown
Member

Summary

Staged frontend dependency upgrade, one commit per batch for bisectability:

Commit Batch
0defbb5a0 minors: vue 3.5.40, vite 8.1.5, tailwindcss 4.3.3, vue-i18n 11.4.8, vitest 4.1.10, mermaid 11.16.0, echarts 6.1.0, electron-builder 26.15.3, plugin-vue 6.0.8, vue-tsc 3.3.8, cronstrue 3.24.0, cron-parser 5.6.2, vue-virtual 3.13.34, vite-plugin-vue-devtools 8.2.1, stream-markdown 0.0.16, @types/node ^25
2018cff22 ESLint 10.8 + eslint-plugin-vue 10.10 + vue-eslint-parser 10.4.1 + typescript-eslint 8.65 + lint-staged 17
fd77f26c6 TypeScript 6.0.3 + @vue/tsconfig 0.9.1
9525213fd vue-router 5.2.0
26a457074 stream-monaco 0.0.49
a12832e00 katex 0.18.1
9061db57b markstream-vue 1.0.1-beta.5 → 1.0.7 (beta → stable)
0c86ccb24 @felinic/ui gitlink → felinics/ui#9 (land that first)

TS 6 — two silent-behavior traps fixed (please review)

  • noUncheckedIndexedAccess re-pinned in web/desktop/ui tsconfigs. @vue/tsconfig 0.9.1 dropped it from its base; without the pin the upgrade silently weakens checking (web typecheck errors fell 471 → 412 before re-pinning — disappearing errors, not fixed code).
  • baseUrl removed (deprecated in TS 6, TS5101) from desktop/ui tsconfigs; paths values carry explicit ./ prefixes instead (TS5090).
  • Added ambient declarations for @fontsource-variable/inter (CSS-only, no shipped types) for TS 6's TS2882 side-effect-import check; also clears one pre-existing TS2307 in web.
  • One real fix forced by vue-tsc 3.3 strictness: step-frame.vue bodyClass: unknown → HTMLAttributes['class'].

Evaluated and deliberately NOT upgraded (evidence in commit messages)

  • pinia 4 / @pinia/colada 1 — both independently break vue-tsc template typing in this repo (~1290 false Property '$t' does not exist errors across 98 files; program-wide loss of vue-i18n's ComponentCustomProperties augmentation under VLS; pure-tsc repro is clean, so it's the VLS layer). colada 1 additionally changes defineQueryOptions → useQuery type inference, breaking @memohai/sdk's generated call sites. Needs upstream/dedicated investigation.
  • shiki 4 — the whole stream stack (stream-monaco pins shiki ^3.23, shiki-stream uses @shikijs/core ^3) is on shiki 3; a direct bump only adds a second copy.
  • monaco-editor 0.56 — violates stream-monaco's peer range (<0.56) and drops the stickyScrollContribution deep import this repo uses.
  • TypeScript 7 — typescript-eslint requires <6.1.0 (TS 7 ships no programmatic compiler API until 7.1).
  • dockview-vue — stays at 7.0.2 + repo patches by owner decision.
  • electron 43 / electron-vite 5 — not needed; electron-vite 4/5 both declare vite peer only up to ^7 (repo already runs vite 8 outside that range without issue).

Verification

  • web typecheck: 466 errors vs 471 baseline — identical modulo 5 pre-existing errors fixed by the upgrade (ES2022 lib + fontsource declaration), zero new
  • desktop + @felinic/ui typecheck: clean
  • eslint (10.8): clean; UI contract guard: pass (baselines unchanged)
  • vitest: parity — same 5 pre-existing desktop server-connection failures as baseline (936 pass / 941)
  • pnpm web:build and @felinic/ui build: pass
  • Smoke-tested via vite dev server against a live backend: chat, markdown rendering, terminal, settings OK (human QA)

Known residuals (disclosed, not blocking)

  • electron-builder-squirrel-windows stays at 26.8.1 inside electron-builder 26.15.3's peer-optional cycle (pnpm overrides don't apply there); affects only future Windows installer builds.
  • ui submodule dependency changes live in chore(deps): bump minor deps and typescript 6 ui#9 — land it before this PR so the gitlink resolves.

Test plan

@qqqqqf-q
qqqqqf-q requested review from a team July 28, 2026 07:39
qqqqqf-q added 10 commits July 28, 2026 19:24
vue 3.5.40, vite 8.1.5, tailwindcss 4.3.3, vue-i18n 11.4.8, vitest 4.1.10,
mermaid 11.16.0, echarts 6.1.0, electron-builder 26.15.3, plugin-vue 6.0.8,
vue-tsc 3.3.8, reka-ui 2.10.1 (ui submodule, pending its own commit),
cronstrue 3.24.0, cron-parser 5.6.2, vue-virtual 3.13.34,
vite-plugin-vue-devtools 8.2.1, stream-markdown 0.0.16, @types/node ^25.

Also fixes one new vue-tsc 3.3 strictness error in step-frame.vue
(bodyClass: unknown -> HTMLAttributes['class']).

Known residual: electron-builder-squirrel-windows stays at 26.8.1 inside
electron-builder 26.15.3's peer-optional cycle (pnpm overrides do not
apply); affects only future Windows installer builds.
eslint 10.8.0, eslint-plugin-vue 10.10.0, vue-eslint-parser 10.4.1,
typescript-eslint 8.65.0, lint-staged 17.2.0. pnpm lint stays clean.
@vue/tsconfig 0.9.1 across web/desktop/ui. Two TS 6 adjustments:
- re-pin noUncheckedIndexedAccess in all three tsconfigs: @vue/tsconfig
  0.9.1 dropped it from its base, which would have silently disabled the
  check (typecheck errors fell 471 -> 412 before re-pinning).
- remove deprecated baseUrl (TS5101) from desktop/ui tsconfigs; paths
  values carry explicit './' prefixes instead (TS5090).
- add ambient declarations for @fontsource-variable/inter (CSS-only
  package, no shipped types) to satisfy TS 6's TS2882 side-effect-import
  check; also clears one pre-existing TS2307 in web.

Verification: web 466 typecheck errors vs 471 baseline (5 fixed, 0 new),
desktop and ui typecheck clean, eslint clean, vitest parity (same 5
pre-existing desktop failures; one previously failing test file now
passes under TS 6).
pinia/@pinia/colada peers of vue-router 5 are optional, so this lands
independently. pinia 4 and @pinia/colada 1 were evaluated in the same
session and deferred: both independently break vue-tsc's template typing
in this repo (~1290 false Property '$t' does not exist errors across 98
files, program-wide loss of vue-i18n's ComponentCustomProperties
augmentation under VLS), and colada 1 additionally changes type inference
between defineQueryOptions and useQuery, breaking @memohai/sdk's

8000
generated colada.gen.ts call sites (DefineQueryOptionsTagged no longer
assignable). Runtime signatures are unchanged; this is a type-level
incompatibility needing dedicated investigation or upstream
(@hey-api/openapi-ts) support.

Verification: web typecheck 466 errors, identical to baseline; eslint
clean; vitest parity (same 5 pre-existing desktop failures).
shiki 4 and monaco-editor 0.56 were evaluated and reverted in the same
session: the entire markdown/stream stack (stream-monaco pins shiki
^3.23 and peers monaco <0.56, shiki-stream uses @shikijs/core ^3) is
still on shiki 3, so a direct shiki 4 bump only adds a second copy
without removing the first, and monaco 0.56 violates stream-monaco's
peer range (plus it drops the stickyScrollContribution deep import this
repo uses). Defer both until stream-monaco supports them.
Typecheck and vitest parity.
Crosses 0.17; typecheck and vitest parity. Formula rendering regression
check left to visual QA.
Beta to stable. New optional peers (d2, infographic, stream-diffs) are
not installed and were not used before; katex/mermaid/stream-monaco/
stream-markdown peers all satisfied. Typecheck and vitest parity.
Chat markdown rendering regression check left to visual QA.
Points at felinics/ui#9 (reka-ui 2.10.1, vite 8.1.5, tailwind 4.3.3,
typescript 6.0.3 with the same noUncheckedIndexedAccess / baseUrl /
fontsource adjustments). Land felinics/ui#9 before this PR.
Found by post-upgrade review: markstream-vue 1.0.7 renamed
.code-block-content to .code-block-shell-content (folding now uses a
--collapsed modifier instead of max-height), leaving the override a dead
rule and silently dropping line-height: 1.5 in chat code blocks.
Font properties survived via the parent selector's inheritance;
retargeting restores line-height only.
@qqqqqf-q
qqqqqf-q force-pushed the chore/frontend-dep-upgrades branch from eb57f8d to e8d1c10 Compare July 29, 2026 02:29
felinics/ui#9 squash-merged as f499363; re-point from the review branch
(b30a27d, now dangling) so the submodule reference resolves from main.
@qqqqqf-q
qqqqqf-q merged commit 00ff24b into felinics:main Jul 29, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0