8000 [pull] main from CPAtoCybersecurity:main by pull[bot] · Pull Request #27 · ericrihm/csf_profile · GitHub
[go: up one dir, main page]

Skip to content

[pull] main from CPAtoCybersecurity:main - #27

Merged
pull[bot] merged 3 commits into
ericrihm:mainfrom
CPAtoCybersecurity:main
Jul 20, 2026
Merged

pull[bot] merged 3 commits into
ericrihm:mainfrom
CPAtoCybersecurity:main

Conversation

@pull
@pull pull Bot commented Jul 20, 2026 •
Copy link
Copy Markdown

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

… toggle

The key chips in the status bar rendered dark navy on the dark navy bar in
light mode (~1.7:1). The bar and the shortcuts-overlay header use --bg-header,
a surface that stays dark in both themes, but their text used --accent, which
flips per theme. Any shared component placed on that chrome inherits the
page-level accent and silently fails in one theme.

Give the always-dark chrome its own vocabulary: --on-header-accent and
--on-header-muted, defined once per theme. --accent is untouched, so nothing
outside the chrome moves.

Auditing for the same shape turned up --text-faint failing 4.5:1 against the
page surface in BOTH themes, across roughly ten sites (row numbers, empty
values, dark placeholders, overlay footer, nav group titles, dark status-bar
labels). Fixed at the token: light #8a93a6 -> #5f6b85, dark #0e6633 -> #12a04a.
Dark --text-muted is lifted to #1fb551 so the ramp does not collapse into two
visual weights once faint clears AA. A new --text-decorative keeps the old
values for the [ ] bracket glyphs, which carry no meaning and are exempt; a
test confines that token to ::before/::after rules. .badge-warning goes
#c97b00 -> #a35f00.

src/theme/contrast.test.js parses index.css with postcss and asserts AA over a
pair matrix, so the colors under test come from the stylesheet rather than a
hand-typed copy that can drift green. A coverage assertion fails the suite when
a new text token is added without being classified.

The platform toggle is display only: useKeyboardNavigation already accepts
ctrlKey || metaKey everywhere, so both renderings are truthful. Detection uses
userAgentData.platform with a userAgent fallback and biases to Windows, since
naming a key the reader does not have is the worse error.
…t guard

Review round on the previous commit. Five findings, all real, all addressed.

The overlay documents "Ctrl/Cmd + Shift + Z" for redo, but browsers report the
SHIFTED character in event.key, so the chord arrived as 'Z' and the hook's
lowercase comparison never matched. Only the Ctrl+Y alternative worked. Caps
Lock broke plain Ctrl+Z the same way. Comparing case-insensitively fixes all
three; a new hook test covers them and fails on the pre-fix code.

Guard hardening, both mutation-proven:
- the token-coverage assertion filtered on a 6-digit-hex value, so a token
  declared as rgb()/hsl()/8-digit-hex slipped through the very check that
  exists to catch unclassified colors. It now excludes by what a value IS (a
  length), so any color notation must be classified.
- the hovered-row surfaces composited a hardcoded accent and asserted only
  that the alpha was unchanged, so recoloring the tint left the test grading
  the old surface. Both the channels and the alpha now come from the
  stylesheet.

postcss was an undeclared dependency, resolving only via react-scripts'
hoisted copy; it is now a devDependency.

The role="group" + aria-label I had put on each row's key list existed only so
a test query could reach it, and made screen readers announce every shortcut
twice. Reverted to the original markup; the test scopes to the row instead,
with one narrow lint exemption and a comment saying why.
…trast-platform

Fix shortcut-chip contrast in both themes; add a Windows/Mac modifier toggle
@pull pull Bot locked and limited conversation to collaborators Jul 20, 2026
@pull pull Bot added the ⤵️ pull label Jul 20, 2026
@pull
pull Bot merged commit ae61a45 into ericrihm:main Jul 20, 2026
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0