Repository navigation
[pull] main from can1357:main - #5
Merged
Merged
Conversation
The status-line branch watcher bound fs.watch to the .git/HEAD file. git updates HEAD via a lock file plus an atomic rename (HEAD.lock -> HEAD), which unlinks the watched inode, so the watch fired for the first branch switch and then died on the stale inode. The displayed branch froze on the previous branch while later switches went unseen. Watch the git directory instead of the HEAD file (and, for reftable repos, the reftable dir as before) and filter directory events for the HEAD entry. The directory inode is stable across renames, so the watch survives every switch. Fixes #8412
Expose the Pi-compatible tui, rpc, json, or print host mode to every extension context and cover mode transitions in the runner regression suite. Fixes #8419
Deferred --tools validation until extension discovery, then validated against built-in and registered tool names while preserving strict rejection of unknown names. Fixes #8421
Legacy Pi extensions build raw tool-parameter documents against real
TypeBox, whose Type.* builders return plain JSON-Schema objects. omptype's
builders return callable schema values instead, so a legacy document that
embeds them (Type.Unsafe({ anyOf: [Type.Array(...), Other] })) or spreads
them (Type.Unsafe({ ...Schema, description })) carries functions. The shim
then structured-cloned that document during plugin install validation and
threw "The object can not be cloned.", rejecting extensions that load fine
when linked (e.g. pi-subagents, all published versions).
Type.Unsafe now lowers embedded builders to their wire JSON and rebuilds
spread documents from the copied run self-reference before cloning or
serializing, matching the plain-object schemas real TypeBox produces.
Fixes #8420
Require the omptype schema brand before treating a raw document's run key as the self-reference copied by a schema spread. This keeps legitimate JSON Schema properties named run intact while retaining spread-schema recovery. Added regression coverage for a required boolean run parameter.
Moved strict --tools validation to the completed session registry so extension modules, custom tool directories, and plugin manifest tools are all eligible while unknown names still fail startup.
Emit pattern, non-URL format, and multipleOf from the TypeBox adapter alongside the runtime narrows that enforce them. Embedded builders lowered by the legacy compatibility shim now retain identical validation constraints in the raw JSON-Schema validator. Added adapter-level wire assertions and an end-to-end unsafe embedding regression.
Kept direct Herdr panes on the host-safe in-place resize path so streaming redraws no longer clear and replay pane scrollback. Updated the resize regression, stress scenario, renderer docs, and changelog. Fixes #8431
Scoped direct Herdr multiplexer behavior to resize repaint selection so explicit transcript replacements continue to clear and replay scrollback. Added coverage for resize stability and resetDisplay ED3 behavior.
…size policy Direct HerdR panes no longer clear/replay via ED3 on resize; the scenario description still claimed the old behavior. Aligns the comment with PR #8433.
Two overlapping `omp update` runs shared the fixed `<binary>.new` temp path. downloadVerifiedBinary unlinks the target before writing, so the second run's unlink deleted the first run's still-downloading temp file; the first kept writing to its open fd (size and digest still passed), then chmod hit the missing path and aborted with ENOENT. Give the temp path the same unique per-attempt suffix the backup path already uses (pid, timestamp, and a new process-local counter that also covers same-millisecond, same-process collisions). Generalize the stale backup sweep to also reclaim orphaned `.new` temp files, age-gated by the download window so a concurrent run's in-progress temp is never deleted. Fixes #8434
Resolved Claude user configuration, plugin, MCP, and session paths through CLAUDE_CONFIG_DIR while retaining the legacy defaults. Fixes #8436
Included the resolved OMP plugin registry path in cache identity and covered shared Claude config directories across isolated SDK homes.
Legacy-path Claude discovery tests now unset an inherited override in beforeEach so they read the fixtures under their temp homes; relocation cases still set it explicitly.
Two overlapping `omp update` runs now share the target only for the swap + stale-artifact sweep, guarded by withFileLock. This closes the rollback race the unique-temp fix left open: a concurrent run's sweep could delete a live run's .bak before its failed verification rolled it back. The download stays outside the lock (unique temp path, safe to overlap). Adds a regression covering a failed verification overlapping a successful update.
The shipped win32-x64 pi_natives addon linked the dynamic MSVC CRT (/MD)
and imported VCRUNTIME140.dll from the Visual C++ Redistributable, which
is absent on a clean Windows install. LoadLibrary of the extracted .node
then failed with error 126 ("The specified module could not be found"),
so omp could not start after a fresh `irm install.ps1 | iex`.
Static-link the CRT for the win32 addon: +crt-static for rustc (crate
BUILD select) plus the static_link_msvcrt cc feature enabled for win32 in
the native_addon transition, so its C deps (opus/cmake, tree-sitter,
blake3, ring) compile /MT in lock-step. The rebuilt .node imports only
core Windows system DLLs -- no VCRUNTIME140.dll, no api-ms-win-crt-*.
Fixes #8439
The win32 addon static-CRT switch enabled the static_link_msvcrt cc feature, but audiopus_sys's bundled opus is built through the generated CMake toolchain, which pinned CMAKE_MSVC_RUNTIME_LIBRARY=MultiThreadedDLL (/MD) as authoritative under CMP0091 NEW. The opus objects could then still emit /MD and pull VCRUNTIME140.dll / conflict with the static CRT the rest of the addon links, leaving the outcome dependent on compile- flag ordering. Pin CMAKE_MSVC_RUNTIME_LIBRARY to MultiThreaded (static release /MT) in the msvc toolchain.cmake so opus deterministically matches rustc's +crt-static and the static_link_msvcrt feature. Verified with a fully cold `bazel build //:natives-win32-x64-baseline` (opus recompiled): the produced .node imports no VCRUNTIME140.dll and no api-ms-win-crt-* — only core Windows system DLLs. Fixes #8439
The executable version probe added in ecb2295 ("validate Linux browser executables") replaced the file-only check in resolveSystemChromium with isChromiumExecutable, which spawns the candidate `--version` for every platform. On Windows chrome.exe is a GUI-subsystem binary: `--version` does not print to a detached stdout and can hand off to a running instance, opening/activating the user's normal browser window, after which the probe rejects the candidate and falls back to cached Chrome for Testing. Gate the spawn probe on process.platform === "linux" (its intended platform, where non-Chromium PATH wrappers are the real risk) and trust the executable-file check on Windows and macOS. Fixes #8445
The HerdR flicker fix routed direct HerdR panes onto the in-place multiplexer resize path, but the randomized render-stress oracle still modeled them as ED3 replaying direct terminals. The width-epoch ledger now applies to any in-place-resize scenario (multiplexer + direct HerdR) via a dedicated resizeRepaintsInPlace trait, keeping HerdR's direct scrollback semantics intact. Adds a deterministic replay regression (seed 0xcafed00d, 24 iterations) that fails without the oracle update.
The deterministic replay oracle only models in-place resize for tmux and direct HerdR, but an inherited PI_TUI_RESIZE_IN_PLACE=1 makes the runtime treat every scenario as in-place and desyncs the oracle. Add the key to the stress env patch so a developer's override cannot leak into replay.
…ds no VC++ redist (@roboomp)
…ialization - Stage transcript initialization inside a detached TranscriptContainer to keep existing messages visible during incremental rendering. - Add fallback state restoration in InteractiveMode.renderInitialMessages when chat rendering is aborted or fails. - Update render-initial-messages tests to assert that old transcripts remain visible until replacements are fully committed.
…ng loops - Replaced time-based sleeps and polling loops with event-driven promise resolvers and fake timers across agent and tool tests. - Migrated test suites to share in-memory auth storage and fixtures using lifecycle hooks. - Updated catalog model definitions, metadata, and configurations.
- Added Gemini 3.7 Flash model definitions and reasoning effort routing configurations. - Implemented geminiLevelFlashFamily in variant-collapse.ts to manage 3.6+ flash thinking levels. - Added test coverage for Gemini 3.7 Flash variant collapse and discovery routing.
…display - Bun's inotify-backed fs.watch permanently stops delivering events after observing git's atomic HEAD.lock -> HEAD rename in the watched directory (oven-sh/bun#24875), so the directory-watch fix for issue #8412 still froze the status-line branch on Linux after the first switch; CI caught it as a 30s timeout in status-line-vcs-refresh.test.ts. - Added git.head.watch: fs.watchFile stat-poll of the HEAD path (reftable dir for reftable repos) with a disposer; path-based polling survives inode swaps on every platform. - Status line and footer now consume the helper; the footer previously bound fs.watch to the HEAD file inode and died after one switch on all platforms. - Dropped the FSWatcher error-listener plumbing (StatWatcher has no error mode) and reworked the watcher lifecycle tests to the stat-poll contract; verified the atomic-rename regression test passes on Linux bun 1.3.14 in Docker where it previously timed out.
… test - The b279db1 rewrite wrapped runner.emit() in vi.useFakeTimers() and hand-advanced the clock, but the runner registers its cap setTimeout after more microtask turns than the test advances (emit defers the timeout machinery to the first matching handler and hops through Bun.sleep(0)), so the cap timer never fires, emit never settles, and fake timers also neutralize bun's per-test timeout — the singleton/global-state CI bucket hung silently until the 600s watchdog SIGKILL (exit 137). - Restored the pre-refactor real-time version: it has no sleeps or polling loops, runs the hung handlers against a 100ms cap, and asserts bounded wall-clock plus the per-extension timeout warnings. - Verified the full 79-file singleton bucket passes (867 tests) and the restored file passes on Linux bun 1.3.14 in Docker. - Restored the original 17.3.1 status-line changelog bullet (released sections stay immutable).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )