Repository navigation
[pull] main from can1357:main - #120
Merged
Merged
Conversation
A basename like generated.go no longer blocks edits by name alone; the file is rejected only when its header carries a generated-code marker. Go's '// Code generated ... DO NOT EDIT.' header is recognized even without 'by'. Fixes #13138
With intent tracing, a call whose `i` exceeds 200 chars is a payload in the wrong field, not a label. Stripping it ran the tool with the leftover args (e.g. write saved a one-line description instead of the body). Return a tool error instead. Fixes #13140
Async follow-ups re-saved the output sink's elided inline body as a new artifact and advertised it as full output. When the job meta already carries the sink's lossless artifact id, link that artifact instead. Fixes #13142
Unknown tools now surface the not-found error first, and tools whose schema declares `i` keep their long values. Pin the 200/201 boundary in the regression test and add the PR link to the changelog entry.
Byte-identical grammar.js, queries/ and src/ from the crates.io 0.25.0 release, wired in through [patch.crates-io] and a first-party Bazel target. No behavior change; the grammar fix follows separately.
Path globs are split into a base directory and a glob relative to it, but native grep prefixed every slash-less glob with **/, so dir/*.go matched dir/<sub>/*.go. Native grep gets a recursive option (default true); the grep tool disables it unless the glob is rooted at cwd (bare *.ts). Fixes #13146
…atement block_range_at no longer climbs into statement-sequence containers (Go statement_list, Python block, Ruby body_statement, ...) that start at the same byte as their first statement and swallowed its siblings. Fixes #13153
The load probe gated on the installed basename matching the host's canonical addon filename, which cannot tell a musl artifact from a gnu one: `ADDON_OUTPUTS` maps `linux-musl-arm64` and `linux-musl-x64-baseline` onto the plain `linux-arm64` / `linux-x64-baseline` filenames on purpose. The release matrix installs `linux-musl-arm64` through the `native-artifacts` action on the glibc `ubuntu-24.04-arm` runner, so the gate matched and the probe dlopened a musl image on glibc, which fails on the loader (`libc.so: cannot open shared object file`) and turned a valid artifact into a failed release build. `linux-musl-x64-baseline` had the same defect latent, reachable whenever the x64 runner lacks AVX2. Gate on target identity instead of filename: `hostProbeFilename` probes only when the invocation actually builds the host's own target, which is never a musl target, and one invocation cannot hold both spellings of a basename because the install loop already refuses duplicates. Also assert the preserved loader output in the negative test by subtracting the known explanation sentence, instead of a length comparison the fixed boilerplate satisfied on its own.
The positive case built the path from platform-arch, which never matches x64 addons (-modern/-baseline suffix), so it silently passed on every x64 host. Resolve via resolveLocalHostAddon and skip visibly. Also document the probe and its musl-host interaction in the script header.
…ries the payload (@radkawar)
… probe On a musl Bun, `host` resolved to the gnu target, whose addon cannot load there; hostTargetName now picks the musl target, detected from the running Bun's ELF interpreter. The load probe is killed after 60s so an addon whose init hangs fails the build instead of stalling it.
# Conflicts: # packages/coding-agent/src/tools/grep.ts
…addon cannot load (@alphastorm) fix(natives): fail the build when an installed host addon cannot load
… stops at that statement (@radkawar)
…o the raw capture (@radkawar)
The agent forwards its host env as session_env, which overwrote the expanded host TEMP with the 8.3 spelling. Share the expansion between both inherited paths, keep Temp/Tmp/TmpDir folding off per-command env, and cover the session path.
feat(tui): filter the esc-esc rewind selector with f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )