8000 [pull] main from can1357:main by pull[bot] · Pull Request #110 · ericrihm/oh-my-pi · GitHub
[go: up one dir, main page]

Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
93 commits
Select commit Hold shift + click to select a range
e9b64e4
fix(ai): preserve required nested nulls in tool argument unions
cswenor Sep 19, 2026
4228b93
docs(ai): attribute nested-null fix to PR #12523
cswenor Sep 19, 2026
a1c9bc7
fix(tui): resolved terminal identity through tmux
roboomp Sep 22, 2026
71cdae8
fix(tui): stop raw-paste classifier from eating stall-batched enter
roboomp Sep 22, 2026
43fbbff
fix(agent): guarded trailing checkSteering in runTool against rejection
roboomp Sep 22, 2026
d3e41fa
fix(agent): isolated aside-commit and discardAsides host callbacks
roboomp Sep 22, 2026
6728002
fix(pi-edit): rejected overlapping sloppy selection spans instead of …
roboomp Sep 22, 2026
9bbb09b
fix(auth): preserved mcp oauth refresh material
roboomp Sep 22, 2026
30a114c
fix(ai): prevented broker identity collisions
roboomp Sep 22, 2026
bcebb7a
fix(macos): added apple events signing entitlement
roboomp Sep 22, 2026
fe68ae9
fix(memories): folded cwd casing into memory scope keys on win32
roboomp Sep 22, 2026
c640631
fix(ai): dropped forced tool_choice from zero-output cache refresh
roboomp Sep 22, 2026
4aa47fc
fix(ai): bounded codex error-body reads with pre-response deadline
roboomp Sep 22, 2026
7d43f28
test(coding-agent): flush the deferred prewarm tick before restoring …
andrebrait Sep 22, 2026
afe24dd
fix(hindsight): cancelled in-flight auto-recall on abort
roboomp Sep 22, 2026
734474e
fix(shell): bounded chunk-forward stall so wedged consumer cannot str…
roboomp Sep 22, 2026
2a597f9
fix(ai): preserve nullable data across union candidate repairs
cswenor Sep 22, 2026
0e03641
Merge PR #12827: fix(ai): drop forced tool_choice from zero-output ca…
can1357 Sep 22, 2026
78cd3b1
chore(ai): drop unrelated changelog reformat
can1357 Sep 22, 2026
564cbad
Merge PR #12813: fix(agent): guard trailing checkSteering in runTool …
can1357 Sep 22, 2026
c88c92c
Merge PR #12820: fix(auth): preserve mcp oauth refresh material (@rob…
can1357 Sep 22, 2026
ef10f7a
Merge PR #12821: fix(ai): prevent auth-broker Team usage collisions (…
can1357 Sep 22, 2026
220d8eb
Merge PR #12826: fix(memories): fold cwd casing into memory scope key…
can1357 Sep 22, 2026
8b88321
Merge PR #12817: fix(pi-edit): reject overlapping sloppy selection sp…
can1357 Sep 22, 2026
5a0fdb0
Merge PR #12810: fix(tui): resolve terminal identity through tmux (@r…
can1357 Sep 22, 2026
8e8d1c3
Merge PR #12833: fix(hindsight): cancel in-flight auto-recall on abor…
can1357 Sep 22, 2026
4f38f72
Merge PR #12811: fix(tui): stop raw-paste classifier from eating stal…
can1357 Sep 22, 2026
86d8b7c
Merge PR #12815: fix(agent): isolate aside-commit / discardAsides hos…
can1357 Sep 22, 2026
8eea854
fix(agent): isolate each aside discard hook
can1357 Sep 22, 2026
52450e1
Merge PR #12823: fix(macos): add Apple Events signing entitlement (@r…
can1357 Sep 22, 2026
36d0024
fix(macos): preserve entitlements in ad hoc signatures
can1357 Sep 22, 2026
3a3ebbf
Merge PR #12831: fix(ai): bound codex error-body reads with the pre-r…
can1357 Sep 22, 2026
57f7c37
test(ai): make codex error timeout regression real
can1357 Sep 22, 2026
d5a6958
Merge PR #12832: fix(shell): bound chunk-forward stall so a wedged co…
can1357 Sep 22, 2026
6fa63dd
docs(changelog): file merged fixes under unreleased and restore relea…
can1357 Sep 22, 2026
b5ecd28
docs(changelog): note hindsight auto-recall cancellation
can1357 Sep 22, 2026
907facc
style: format merged files with oxfmt
can1357 Sep 22, 2026
76d4da4
fix(ai): hardened custom OpenAI streamer compatibility
can1357 Sep 22, 2026
4fc8ad7
fix(catalog): curated xiaomi mimo v2.6 metadata
roboomp Sep 22, 2026
55b3b60
fix(lsp): preferred formatter servers for formatOnWrite
roboomp Sep 22, 2026
9009956
fix(eval): persisted async binding assignments
can1357 Sep 22, 2026
bb863d9
feat(collab): publish whether a host session is working
alphastorm Sep 22, 2026
52eb196
fix(coding-agent): preserve provider transport on custom models
joshrzemien Sep 22, 2026
0c5078b
docs(coding-agent): attribute custom model transport fix
joshrzemien Sep 22, 2026
bb14f7d
fix(extensions): exempt omp-origin marketplace plugins from dashboard…
roboomp Sep 22, 2026
96a5a29
fix(ai): dropped Gemini-unsupported minP/repetitionPenalty from googl…
roboomp Sep 22, 2026
244039a
Merge upstream main into fix/nested-union-null-arguments
cswenor Sep 22, 2026
069eddf
fix(coding-agent): suspend loop on Esc even mid-iteration
Sep 22, 2026
95776f0
fix(natives): resolved wayland keyboard input through the active xkb …
can1357 Sep 22, 2026
e8ed183
style: format custom api compat test with oxfmt
can1357 Sep 22, 2026
ce64ccb
fixup(collab): busy scheduling-pause note and null-branch CLI test
Sep 22, 2026
1eb2f51
Merge pull request #12844 from alphastorm/contrib/collab-snapshot-busy
H4vC Sep 22, 2026
d51c251
fix(extensions): bound extension api methods
roboomp Sep 22, 2026
9de461c
Merge remote-tracking branch 'origin/main'
can1357 Sep 22, 2026
fcac430
fix(lsp): refreshed diagnostics after workspace changes
roboomp Sep 22, 2026
a8563df
fix(catalog): restored legacy Devin discovery
roboomp Sep 22, 2026
3b81deb
fix(ai): parsed Kimi monthly usage quotas
roboomp Sep 22, 2026
7fd302e
Merge pull request #12851 from H4vC/fix/loop-esc-suspends
H4vC Sep 22, 2026
88b1e7f
fix(bedrock): hoisted images out of error toolResults
roboomp Sep 22, 2026
aedf39a
Merge remote-tracking branch 'origin/main'
can1357 Sep 22, 2026
c93d5a8
fix(coding-agent): prevented queued turns from starting on disposed s…
can1357 Sep 22, 2026
0951125
Merge PR #12858: fix(catalog): restore legacy Devin discovery (@roboomp)
can1357 Sep 22, 2026
aeee9d3
Merge PR #12857: fix(lsp): refresh diagnostics after workspace change…
can1357 Sep 22, 2026
ce18e7e
Merge PR #12855: fix(ai): parse Kimi monthly usage quotas (@roboomp)
can1357 Sep 22, 2026
1f7329f
docs(changelog): add unreleased entries for merged fixes
can1357 Sep 22, 2026
ef1418b
Merge PR #12856: fix(extensions): bind ExtensionAPI methods (@roboomp)
can1357 Sep 22, 2026
f766250
fix(extensions): bound every ExtensionAPI prototype method structurally
can1357 Sep 22, 2026
0684895
test(agent): covered shared siblings in the steering-callback rejecti…
can1357 Sep 22, 2026
30cf205
chore: rewrite changelogs
can1357 Sep 22, 2026
0a4dfe1
chore: opus 5.5 support
can1357 Sep 22, 2026
d7383cf
Merge PR #12865: fix(bedrock): hoist images out of error toolResults …
can1357 Sep 22, 2026
a9fc2d6
Merge PR #12847: fix(lsp): prefer formatter servers for formatOnWrite…
can1357 Sep 22, 2026
bef387b
Merge PR #12850: fix(ai): drop Gemini-unsupported minP/repetitionPena…
can1357 Sep 22, 2026
146979d
Merge PR #12863: test(coding-agent): flush the deferred prewarm tick …
can1357 Sep 22, 2026
b225424
Merge PR #12523: fix(ai): preserve required nested nulls in tool argu…
can1357 Sep 22, 2026
2088948
Merge PR #12845: fix(coding-agent): preserve provider transport on cu…
can1357 Sep 22, 2026
7eb681a
Merge PR #12849: fix(extensions): exempt omp-origin marketplace plugi…
can1357 Sep 22, 2026
df3aa7c
Merge PR #12841: fix(catalog): curate xiaomi mimo v2.6 metadata (@rob…
can1357 Sep 22, 2026
da359ef
docs(changelog): add unreleased entries for merged fixes
can1357 Sep 22, 2026
a2e4e7a
chore: cleanup tests
can1357 Sep 22, 2026
4d52859
chore: bump version to 18.2.9
can1357 Sep 22, 2026
9a7b3f0
test(catalog): removed legacy umans-provider test suite
can1357 Sep 22, 2026
2282226
feat: implemented Claude Code dynamic versioning and fallback retries
can1357 Sep 22, 2026
652c9ef
fix(natives): added wayland xkb test fixtures to bazel compile_data
can1357 Sep 22, 2026
06f834e
test(catalog): dropped zenmux default-model literal assertions
can1357 Sep 22, 2026
7fcbfb6
fix(natives): satisfied clippy-strict in wayland xkb and libei
can1357 Sep 22, 2026
8cdf508
test(coding-agent): resolved anthropic default from descriptors in fa…
can1357 Sep 22, 2026
3d4d323
feat: implemented anthropic claude usage reset support and automated …
can1357 Sep 22, 2026
8cd6f8c
test(coding-agent): updated /usage reset metadata expectation
can1357 Sep 22, 2026
e45b49c
fix(ai): probed claude resets when usage lists null program blocks
roboomp Sep 22, 2026
3bb803a
chore: add latest gpt models & auto update version
can1357 Sep 22, 2026
6e568e9
Merge remote-tracking branch 'origin/farm/a6b86987/fix-claude-reset-n…
can1357 Sep 22, 2026
b52e1f5
feat(coding-agent): added live judgment batch progress UI and perform…
can1357 Sep 22, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -674,9 +674,9 @@ jobs:
run: bun run ci:release:build-binaries
- name: Sign and notarize macOS binary (Developer ID)
# Replaces the ad-hoc signature with a Developer ID + hardened-runtime
# one (+JIT/library-validation entitlements; omp dlopens its
# runtime-extracted native addon, which has a different Team ID) and
# notarizes. Auto-skips until the APPLE_* secrets are configured.
# one while preserving the required JIT, Apple Events, and
# library-validation entitlements, then notarizes. Auto-skips until
# the APPLE_* secrets are configured.
if: matrix.platform == 'darwin' && env.MACOS_SIGNING == 'true'
env:
APPLE_CERTIFICATE_P12: ${{ secrets.APPLE_CERTIFICATE_P12 }}
Expand Down
36 changes: 18 additions & 18 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ members = [
resolver = "3"

[workspace.package]
version = "18.2.8"
version = "18.2.9"
edition = "2024"
license = "MIT"
authors = ["Stencil Labs, Inc."]
Expand Down
124 changes: 62 additions & 62 deletions MODULE.bazel.lock

Large diffs are not rendered by default.

52 changes: 26 additions & 26 deletions bun.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 38 additions & 1 deletion crates/pi-edit/src/modes/sloppy/apply.rs
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,36 @@ fn source_end(normalized: &NormalizedText, offset: usize, fallback: usize) -> us
normalized.ends.get(offset - 1).copied().unwrap_or(fallback)
}
}

/// Whether a candidate's selection spans can be applied without corrupting the
/// rewrite.
///
/// Consumers ([`rewrite_selection_spans`], the ambiguity-outcome projector, and
/// [`rewrite_proves_whole_span`]) assume the spans are ordered,
/// non-overlapping, distinct-start sub-ranges of `[start, end]`. Garbled `⟪…⟫`
/// marker glyphs can resolve pairs that overlap or fall outside that range;
/// splicing such a pair would index `content` (or the mutated
/// `content[start..end]` buffer) on an out-of-range or mid-char edge and panic
/// the worker instead of reporting a miss. Rejecting the candidate lets the
/// miss surface as an [`EditError`].
fn selection_spans_usable(spans: &[(usize, usize)], start: usize, end: usize) -> bool {
let mut ordered: Vec<(usize, usize)> = spans.to_vec();
ordered.sort_unstable();
let mut cursor = start;
let mut previous_start: Option<usize> = None;
for (span_start, span_end) in ordered {
if span_start < cursor
|| span_start > span_end
|| span_end > end
|| previous_start == Some(span_start)
{
return false;
}
previous_start = Some(span_start);
cursor = span_end;
}
true
}
fn preceding_literal(tokens: &[PatternToken], boundary: usize) -> Option<usize> {
(0..boundary)
.rev()
Expand Down Expand Up @@ -717,7 +747,14 @@ fn collect_candidates(
)
})
.collect::<Vec<_>>();
if selection_spans.iter().any(|(start, end)| start > end) {
// Every selection span must be an ordered, non-overlapping,
// char-boundary sub-range of the candidate's own [start, end].
// Garbled marker glyphs can otherwise resolve overlapping or
// out-of-range pairs that later slice `content` (or the
// `content[start..end]` rewrite buffer) on a mid-char or
// out-of-range edge and panic the worker instead of reporting a
// miss.
if !selection_spans_usable(&selection_spans, start, end) {
return;
}
let candidate = Candidate {
Expand Down
19 changes: 19 additions & 0 deletions crates/pi-edit/tests/sloppy.rs
Original file line number Diff line number Diff line change
Expand Up @@ -376,3 +376,22 @@ async fn miss_with_cjk_content_returns_match_error_without_panicking() {
.expect_err("CJK miss must surface a match error, not panic");
assert!(error.to_string().contains("did not match"));
}

#[tokio::test]
async fn overlapping_selection_spans_report_a_miss_without_panicking() {
// Garbled ⟪…⟫ marker glyphs can resolve overlapping selection spans. Splicing
// a multibyte (CJK) replacement into the mutated `content[start..end]` rewrite
// buffer then re-indexes it on a mid-char edge and panicked the worker instead
// of reporting the miss. The unmappable selection must surface as a match
// error. (#12529)
let workspace = Workspace::new(EditMode::Sloppy);
workspace.write("a.txt", "d");
let writer = DiskWriter::default();
let error = workspace
.apply_raw("*** SM:EDIT a.txt\n*** SM:FIND\n⟫⟪⟫d⟪\n*** SM:PUT\n戸", &writer)
.await
.expect_err("an unmappable selection reports a miss instead of panicking");
assert!(matches!(error, EditError::Match(_)));
assert!(writer.requests.lock().is_empty());
assert_eq!(workspace.read("a.txt").unwrap(), "d");
}
1 change: 1 addition & 0 deletions crates/pi-natives/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ rust_shared_library(
"src/fonts/*",
"data/*.bin.zst",
"src/utok/claude/testdata/*.json",
"src/desktop/linux/wayland/testdata/*.xkb",
"fixtures/*.json",
]) + select({
"@platforms//os:macos": [":oauth_callback_darwin_helper"],
Expand Down
Loading
Loading
0