8000 add CI checks by GitGab19 · Pull Request #35 · edge-mining/app · GitHub
[go: up one dir, main page]

Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 89 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,89 @@
name: CI

on:
pull_request:
branches:
- main
workflow_dispatch:

permissions:
contents: read

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
backend:
name: Backend
runs-on: ubuntu-latest
timeout-minutes: 20

defaults:
run:
working-directory: core

steps:
- name: Checkout
uses: actions/checkout@v4

- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.11"
cache: pip
cache-dependency-path: |
core/requirements.txt
core/requirements-dev.txt

- name: Install dependencies
run: |
python -m pip install --upgrade pip
python -m pip install -r requirements.txt -r requirements-dev.txt

- name: Check formatting
run: python -m ruff format --check edge_mining/ tests/

- name: Lint
run: python -m ruff check edge_mining/

- name: Run tests
run: python -m pytest tests/ -v

frontend:
name: Frontend
runs-on: ubuntu-latest
timeout-minutes: 15

defaults:
run:
working-directory: frontend

steps:
- name: Checkout
uses: actions/checkout@v4

- name: Set up Node
uses: actions/setup-node@v4
with:
node-version: "22"
cache: npm
cache-dependency-path: frontend/package-lock.json

- name: Install dependencies
run: npm ci

- name: Build
run: npm run build

docker:
name: Docker
runs-on: ubuntu-latest
timeout-minutes: 20

steps:
- name: Checkout
uses: actions/checkout@v4

- name: Build image
run: docker build .
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
"""Collection of Adapters (Implementations of Ports) that driving the configuration service of Edge Mining Application"""
"""Collection of Adapters (Implementations of Ports) that driving the configuration
service of Edge Mining Application"""
6 changes: 2 additions & 4 deletions core/edge_mining/adapters/domain/home_load/repositories.py
Original file line number Diff line number Diff line change
Expand Up @@ -354,8 +354,7 @@ def _deserialize_config(
config_instance = config_class.from_dict(data)
if not isinstance(config_instance, EnergyLoadForecastProviderConfig):
raise EnergyLoadForecastProviderConfigurationError(
f"Deserialized config is not of type EnergyLoadForecastProviderConfig "
f"for adapter type {adapter_type}."
f"Deserialized config is not of type EnergyLoadForecastProviderConfig for adapter type {adapter_type}."
)
return config_instance

Expand Down Expand Up @@ -1085,8 +1084,7 @@ def _deserialize_config(
config_instance = config_class.from_dict(data)
if not isinstance(config_instance, EnergyLoadHistoryProviderConfig):
raise EnergyLoadHistoryProviderConfigurationError(
f"Deserialized config is not of type EnergyLoadHistoryProviderConfig "
f"for adapter type {adapter_type}."
f"Deserialized config is not of type EnergyLoadHistoryProviderConfig for adapter type {adapter_type}."
)
return config_instance

Expand Down
4 changes: 3 additions & 1 deletion core/edge_mining/adapters/domain/miner/repositories.py
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,9 @@ def _save_features(self, conn: sqlite3.Connection, miner_id: EntityId, features:
conn.execute(f"DELETE FROM {self.FEATURES_TABLE_NAME} WHERE miner_id = ?", (str(miner_id),))
for f in features:
conn.execute(
f"INSERT INTO {self.FEATURES_TABLE_NAME} (miner_id, controller_id, feature_type, priority, enabled) VALUES (?, ?, ?, ?, ?)",
f"INSERT INTO {self.FEATURES_TABLE_NAME} "
"(miner_id, controller_id, feature_type, priority, enabled) "
"VALUES (?, ?, ?, ?, ?)",
(str(miner_id), str(f.controller_id), f.feature_type.value, f.priority, int(f.enabled)),
)

Expand Down
8 10BC8
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ async def _cached_call(
if cached is not None:
if self._cache_logger:
self._cache_logger.warning(
f"Rate-limited on '{key}': serving stale cached value " f"({int(now - cached.stored_at)}s old)."
f"Rate-limited on '{key}': serving stale cached value ({int(now - cached.stored_at)}s old)."
)
return cached.value # type: ignore[no-any-return]
raise
Expand Down
3 changes: 2 additions & 1 deletion core/edge_mining/application/services/adapter_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -849,7 +849,8 @@ def get_home_load_forecast_provider(
if not energy_load_forecast_provider:
if self.logger:
self.logger.error(
f"Home Forecast Provider ID {energy_load_forecast_provider_id} not found or not a Home Forecast Provider."
f"Home Forecast Provider ID {energy_load_forecast_provider_id} "
"not found or not a Home Forecast Provider."
)
return None
return self._initialize_energy_load_forecast_provider_adapter(energy_load_forecast_provider)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1673,7 +1673,8 @@ async def set_miner_feature_priority(
) -> Miner:
"""Set the priority of a specific feature on a miner."""
self.logger.info(
f"Setting priority {priority} for feature {feature_type} from controller {controller_id} on miner {miner_id}"
f"Setting priority {priority} for feature {feature_type} "
f"from controller {controller_id} on miner {miner_id}"
)
miner = self.miner_repo.get_by_id(miner_id)
if not miner:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ async def _collect_for_device(
except Exception as e:
if self.logger:
self.logger.error(
f"Error fetching power points for device '{device_name}' " f"from provider {provider_id}: {e}"
f"Error fetching power points for device '{device_name}' from provider {provider_id}: {e}"
)
return

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,8 @@ def _train_skforecast(
backtest_folds = bt_result.get("backtest_folds", 0)
if self._logger:
self._logger.debug(
f"Backtesting for '{device_name}': MAE={backtest_mae}, RMSE={backtest_rmse}, folds={backtest_folds}"
f"Backtesting for '{device_name}': MAE={backtest_mae}, "
f"RMSE={backtest_rmse}, folds={backtest_folds}"
)
except Exception as bt_exc:
if self._logger:
Expand Down
9 changes: 6 additions & 3 deletions core/edge_mining/application/services/optimization_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -462,14 +462,16 @@ async def get_decisional_context(self, optimization_unit_id: EntityId) -> Option
if not miner.active:
if self.logger:
self.logger.warning(
f"Miner {miner_id} in optimization unit '{optimization_unit.name}' is not active. Skipping miner."
f"Miner {miner_id} in optimization unit '{optimization_unit.name}' "
"is not active. Skipping miner."
)
continue # Try next miner if available

if not miner.get_controller_ids():
if self.logger:
self.logger.warning(
f"Miner {miner_id} in optimization unit '{optimization_unit.name}' has no controllers. Skipping miner."
f"Miner {miner_id} in optimization unit '{optimization_unit.name}' "
"has no controllers. Skipping miner."
)
continue # Try next miner if available

Expand Down Expand Up @@ -1157,7 +1159,8 @@ async def _execute_miner_decision(
if not success:
if self.logger:
self.logger.error(
f"Command {decision.name} for miner {miner_id} failed using controller {type(mining_port).__name__}."
f"Command {decision.name} for miner {miner_id} "
f"failed using controller {type(mining_port).__name__}."
)
else:
miner = self.miner_repo.get_by_id(miner_id)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -397,9 +397,7 @@ def test_parse_timestamp_handles_unix_and_iso():
from edge_mining.adapters.domain.performance.trackers.braiins_pool import _parse_timestamp

assert _parse_timestamp(1_700_000_000) == datetime(2023, 11, 14, 22, 13, 20, tzinfo=timezone.utc)
assert _parse_timestamp("2023-11-14T22:13:20+00:00") == datetime(
2023, 11, 14, 22, 13, 20, tzinfo=timezone.utc
)
assert _parse_timestamp("2023-11-14T22:13:20+00:00") == datetime(2023, 11, 14, 22, 13, 20, tzinfo=timezone.utc)
assert _parse_timestamp(None) is None


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -189,9 +189,7 @@ def test_print_tracker_details_includes_config() -> None:
# -- Add ----------------------------------------------------------------------


def test_handle_add_invokes_configuration_service(
configuration_service: MagicMock, logger: MagicMock
) -> None:
def test_handle_add_invokes_configuration_service(configuration_service: MagicMock, logger: MagicMock) -> None:
"""handle_add_mining_performance_tracker calls add on the service when config is valid."""
added_tracker = _make_tracker(MiningPerformanceTrackerAdapter.DUMMY)
configuration_service.add_mining_performance_tracker = AsyncMock(return_value=added_tracker)
Expand All @@ -209,9 +207,7 @@ def test_handle_add_invokes_configuration_service(
# -- Update -------------------------------------------------------------------


def test_update_single_keeps_configuration_when_declined(
configuration_service: MagicMock, logger: MagicMock
) -> None:
def test_update_single_keeps_configuration_when_declined(configuration_service: MagicMock, logger: MagicMock) -> None:
"""Declining the configuration change still forwards the existing config."""
tracker = _make_tracker(MiningPerformanceTrackerAdapter.DUMMY)
configuration_service.update_mining_performance_tracker = AsyncMock(return_value=tracker)
Expand All @@ -236,9 +232,7 @@ def test_update_single_keeps_configuration_when_declined(
# -- Delete -------------------------------------------------------------------


def test_delete_single_cancels_on_negative_confirm(
configuration_service: MagicMock, logger: MagicMock
) -> None:
def 10BC8 test_delete_single_cancels_on_negative_confirm(configuration_service: MagicMock, logger: MagicMock) -> None:
"""The delete helper cancels when the user declines confirmation."""
tracker = _make_tracker()
runner = CliRunner()
Expand All @@ -256,9 +250,7 @@ def test_delete_single_cancels_on_negative_confirm(
configuration_service.remove_mining_performance_tracker.assert_not_called()


def test_delete_single_invokes_service_on_confirm(
configuration_service: MagicMock, logger: MagicMock
) -> None:
def test_delete_single_invokes_service_on_confirm(configuration_service: MagicMock, logger: MagicMock) -> None:
"""Confirming deletion forwards the call to the configuration service."""
tracker = _make_tracker()
configuration_service.remove_mining_performance_tracker = AsyncMock(return_value=tracker)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,7 @@ def test_get_details_missing_returns_404(client: TestClient, config_service: Mag
# -- Create -------------------------------------------------------------------


def test_create_tracker_accepts_dummy_config(
client: TestClient, config_service: MagicMock, dummy_tracker
) -> None:
def test_create_tracker_accepts_dummy_config(client: TestClient, config_service: MagicMock, dummy_tracker) -> None:
"""POST /mining-performance-trackers creates a tracker and returns its schema."""
config_service.add_mining_performance_tracker = AsyncMock(return_value=dummy_tracker)

Expand Down Expand Up @@ -217,9 +215,7 @@ def test_create_tracker_rejects_invalid_adapter_type(client: TestClient) -> None
# -- Update -------------------------------------------------------------------


def test_update_tracker_persists_new_config(
client: TestClient, config_service: MagicMock, dummy_tracker
) -> None:
def test_update_tracker_persists_new_config(client: TestClient, config_service: MagicMock, dummy_tracker) -> None:
"""PUT /mining-performance-trackers/{id} updates a tracker's configuration."""
config_service.get_mining_performance_tracker.return_value = dummy_tracker
config_service.get_mining_performance_tracker_config_by_type.return_value = MiningPerformanceTrackerDummyConfig
Expand Down Expand Up @@ -255,9 +251,7 @@ def test_update_missing_tracker_returns_404(client: TestClient, config_service:
# -- Remove -------------------------------------------------------------------


def test_remove_tracker_returns_deleted_schema(
client: TestClient, config_service: MagicMock, dummy_tracker
) -> None:
def test_remove_tracker_returns_deleted_schema(client: TestClient, config_service: MagicMock, dummy_tracker) -> None:
"""DELETE /mining-performance-trackers/{id} returns the removed tracker."""
config_service.remove_mining_performance_tracker = AsyncMock(return_value=dummy_tracker)

Expand Down Expand Up @@ -380,9 +374,7 @@ def test_stats_endpoint_returns_pool_stats(client: TestClient, adapter_service:
)
],
)
adapter_service.get_mining_performance_tracker = AsyncMock(
return_value=_FakeTrackerPort(stats=stats)
)
adapter_service.get_mining_performance_tracker = AsyncMock(return_value=_FakeTrackerPort(stats=stats))

response = client.get(f"/api/v1/mining-performance-trackers/{uuid.uuid4()}/stats")
assert response.status_code == 200
Expand All @@ -406,9 +398,7 @@ def test_workers_endpoint_returns_worker_stats(client: TestClient, adapter_servi
PoolWorkerStats(worker_name="w1", valid_shares=10),
PoolWorkerStats(worker_name="w2", valid_shares=20),
]
adapter_service.get_mining_performance_tracker = AsyncMock(
return_value=_FakeTrackerPort(workers=workers)
)
adapter_service.get_mining_performance_tracker = AsyncMock(return_value=_FakeTrackerPort(workers=workers))
response = client.get(f"/api/v1/mining-performance-trackers/{uuid.uuid4()}/workers")
assert response.status_code == 200
body = response.json()
Expand All @@ -419,9 +409,7 @@ def test_rewards_endpoint_respects_limit(client: TestClient, adapter_service: Ma
"""GET /{id}/rewards returns rewards honoring the limit query parameter."""
now = datetime.now(timezone.utc)
rewards = [MiningReward(amount=Satoshi(i * 1000), timestamp=now) for i in range(1, 6)]
adapter_service.get_mining_performance_tracker = AsyncMock(
return_value=_FakeTrackerPort(rewards=rewards)
)
adapter_service.get_mining_performance_tracker = AsyncMock(return_value=_FakeTrackerPort(rewards=rewards))

response = client.get(
f"/api/v1/mining-performance-trackers/{uuid.uuid4()}/rewards",
Expand All @@ -436,9 +424,7 @@ def test_rewards_endpoint_respects_limit(client: TestClient, adapter_service: Ma
def test_payout_schedule_endpoint_returns_schema(client: TestClient, adapter_service: MagicMock) -> None:
"""GET /{id}/payout-schedule returns the payout schedule schema."""
schedule = PayoutSchedule(frequency=PayoutFrequency.THRESHOLD, threshold=Satoshi(100_000))
adapter_service.get_mining_performance_tracker = AsyncMock(
return_value=_FakeTrackerPort(payout_schedule=schedule)
)
adapter_service.get_mining_performance_tracker = AsyncMock(return_value=_FakeTrackerPort(payout_schedule=schedule))
response = client.get(f"/api/v1/mining-performance-trackers/{uuid.uuid4()}/payout-schedule")
assert response.status_code == 200
body = response.json()
Expand Down
13 changes: 4 additions & 9 deletions core/tests/unit/adapters/domain/performance/test_tracker_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ def tracker() -> _Tracker:
@pytest.fixture(autouse=True)
def _no_sleep():
"""Replace ``asyncio.sleep`` with an immediate no-op for all tests."""

async def _fast_sleep(_delay: float) -> None:
return None

Expand Down Expand Up @@ -139,9 +140,7 @@ async def test_with_backoff_applies_scheduled_delays(tracker: _Tracker, _no_slee

@pytest.mark.asyncio
async def test_with_backoff_succeeds_on_later_attempt(tracker: _Tracker, _no_sleep) -> None:
fetch = _counter_fetch(
[MiningPoolRateLimitedError(), MiningPoolRateLimitedError(), "ok"]
)
fetch = _counter_fetch([MiningPoolRateLimitedError(), MiningPoolRateLimitedError(), "ok"])
result = await tracker._with_backoff(fetch)
assert result == "ok"
# Two failed attempts → two sleeps before the success.
Expand Down Expand Up @@ -185,18 +184,14 @@ def now() -> float:
t[0] += 10.0

# All retries raise 429 → the stale value should be returned.
fetch_429 = _counter_fetch(
[MiningPoolRateLimitedError()] * len(_BACKOFF_SCHEDULE_SECONDS)
)
fetch_429 = _counter_fetch([MiningPoolRateLimitedError()] * len(_BACKOFF_SCHEDULE_SECONDS))
result = await tracker._cached_call("short", fetch_429)
assert result == "fresh"


@pytest.mark.asyncio
async def test_rate_limit_re FA94 raises_when_no_cached_value(tracker: _Tracker) -> None:
fetch = _counter_fetch(
[MiningPoolRateLimitedError("hard fail")] * len(_BACKOFF_SCHEDULE_SECONDS)
)
fetch = _counter_fetch([MiningPoolRateLimitedError("hard fail")] * len(_BACKOFF_SCHEDULE_SECONDS))
with pytest.raises(MiningPoolRateLimitedError):
await tracker._cached_call("short", fetch)

Expand Down
3 changes: 3 additions & 0 deletions core/tests/unit/adapters/home_load/test_backtesting.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
# Helpers
# ---------------------------------------------------------------------------


def _make_series(hours: int = 300):
"""Create a pandas Series of synthetic hourly power values."""
import pandas as pd
Expand All @@ -42,6 +43,7 @@ def _fit_forecaster(y, lags: int = 24):
# backtest() static method tests
# ---------------------------------------------------------------------------


class TestSkforecastBacktest:
"""Tests for SkforecastForecastProvider.backtest()."""

Expand Down Expand Up @@ -132,6 +134,7 @@ def test_backtest_too_short_series_returns_zeros(self):
# LoadConsumptionModel backtest fields tests
# ---------------------------------------------------------------------------


class TestLoadConsumptionModelBacktestFields:
"""Tests for backtest_mae/rmse/folds fields on the entity."""

Expand Down
Loading
Loading
0