Repository navigation
Fixed JSON.parse() failing on numbers that overflow float64 - #874
Merged
Merged
Conversation
encoding/json's Decoder.Token() returns numbers as float64 and fails with an error for values like 1e400, which JSON.parse() must return as Infinity. Read numbers as json.Number and convert them with strconv.ParseFloat, which gives ±Inf on overflow. Fixes #873.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #873.
JSON.parse('1e400')threwSyntaxError: json: cannot unmarshal number 1e400 into Go value of type float64instead of returningInfinity.encoding/json'sDecoder.Token()decodes numbers intofloat64and errors out when the value overflows.The decoder now uses
UseNumber(), and thejson.Numbertoken is converted withstrconv.ParseFloat. On overflow it returns±Inftogether withErrRange, which is what JSON.parse needs, soErrRangeis ignored. Underflow (1e-400→ 0) and-0behave as before.Testing: added
TestJSONParseNumberOverflow(fails on master, passes now).go test ./...(with test262),go vetandgofmtare clean.