8000 Split the readers and the JavaScript values of jetdb-wasm, and the complexity filter, into functions of their own by dominion525 · Pull Request #141 · dominion525/jetdb · GitHub
[go: up one dir, main page]

Skip to content

Split the readers and the JavaScript values of jetdb-wasm, and the complexity filter, into functions of their own - #141

Merged
dominion525 merged 3 commits into
mainfrom
refactor/wasm
Oct 26, 2026
Merged

dominion525 merged 3 commits into
mainfrom
refactor/wasm

Conversation

@dominion525
Copy link
Copy Markdown
Owner

Summary

  • Database::properties chooses the only entry of the name, reads the properties by the name alone when the catalog has none, and groups the properties read, in functions of their own. rows_from chooses the shown columns and reads the cells of the rows up to the limit, relationships converts each relationship, and queries tells a system or hidden query, in functions of their own.
  • In js.rs, the type option of properties, the ObjectProperties object, the branches of an If and the object of a record are made in functions of their own.
  • The complexity filter of scripts/quality-check.sh reads the functions above the thresholds and prints their table in functions of their own. Its output is the same before and after for the analysis of the whole code, an empty input, lines that are not JSON, and lines that are not UTF-8, which it passes over as before.
  • The values given to JavaScript, and the errors and their messages, are unchanged; the tests of jetdb-wasm and of the package in Node.js and the browser pass.
  • Functions above the thresholds: 37 → 29. Tests: 1115, as before. query_type_name and actionNames of the TypeScript check are kept as the matches over the query types and the macro actions.
Function Before (CC / Cog / SLOC) After, the function of the largest CC
lib.rs properties 22 / 11 / 62 9 / 1 / 17
lib.rs rows_from 11 / 2 / 44 7 / 0 / 36
lib.rs relationships 10 / 2 / 30 8 / 2 / 15
lib.rs queries 10 / 2 / 23 6 / 1 / 18
js.rs properties 11 / 1 / 35 8 / 1 / 16
js.rs statement_object 10 / 1 / 56 9 / 1 / 47
js.rs cell_value 10 / 3 / 18 9 / 1 / 12
complexity-filter main 14 / 11 / 49 5 / 7 / 20

🤖 Generated with Claude Code

dominion525 and others added 3 commits October 26, 2026 14:36
…of jetdb-wasm into functions of their own

- Choose the only entry of the name, read the properties by the name alone, and group the properties read, in functions of their own
- Choose the shown columns and read the cells of the rows up to the limit, convert a relationship, and tell a system or hidden query, in functions of their own

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…functions of their own

- Read the type option and make the ObjectProperties object, the branches of an If and the object of a record in functions of their own

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…tions of their own

- Pass over the lines that cannot be read or are not JSON of a file as before

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

Coverage

For ca2641c.

Filename                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
jetdb-cli/src/export.rs            113                11    90.27%           6                 0   100.00%          65                 6    90.77%           0                 0         -
jetdb-cli/src/form.rs              239                19    92.05%          24                 5    79.17%         151                 6    96.03%           0                 0         -
jetdb-cli/src/macro_cmd.rs         117                10    91.45%           7                 2    71.43%          62                 4    93.55%           0                 0         -
jetdb-cli/src/main.rs              910                39    95.71%          82                 4    95.12%         578                28    95.16%           0                 0         -
jetdb-cli/src/prop.rs              322                18    94.41%          37                 2    94.59%         185                 7    96.22%           0                 0         -
jetdb-cli/src/query.rs              65                 3    95.38%           5                 0   100.00%          32                 0   100.00%           0                 0         -
jetdb-cli/src/vba.rs                59                 3    94.92%           5                 0   100.00%          28                 0   100.00%           0                 0         -
jetdb-wasm/src/lib.rs             3901                96    97.54%         257                 4    98.44%        2058                22    98.93%           0                 0         -
jetdb/src/catalog.rs               509                14    97.25%          46                 0   100.00%         299                 3    99.00%           0                 0         -
jetdb/src/complex.rs               924                32    96.54%          73                 0   100.00%         605                15    97.52%           0                 0         -
jetdb/src/crypto.rs               2300               112    95.13%         127                10    92.13%        1315                60    95.44%           0                 0         -
jetdb/src/csv.rs                   857                24    97.20%          72                 0   100.00%         486                 6    98.77%           0                 0         -
jetdb/src/data.rs                 4560               179    96.07%         257                 3    98.83%        2564               110    95.71%           0                 0         -
jetdb/src/ddl/access.rs             70                 0   100.00%           7                 0   100.00%          46                 0   100.00%           0                 0         -
jetdb/src/ddl/mod.rs              2771                 8    99.71%         208                 2    99.04%        1501                 6    99.60%           0                 0         -
jetdb/src/ddl/mysql.rs              70                 0   100.00%           7                 0   100.00%          46                 0   100.00%           0                 0         -
jetdb/src/ddl/postgres.rs           71                 0   100.00%           7                 0   100.00%          46                 0   100.00%           0                 0         -
jetdb/src/ddl/sqlite.rs             69                 0   100.00%           7                 0   100.00%          48                 0   100.00%           0                 0         -
jetdb/src/encoding.rs              284                 0   100.00%          30                 0   100.00%         153                 0   100.00%           0                 0         -
jetdb/src/file.rs                 1915                65    96.61%         117                 0   100.00%         983                18    98.17%           0                 0         -
jetdb/src/form.rs                 3123               128    95.90%         230                10    95.65%        1684                48    97.15%           0                 0         -
jetdb/src/form2000.rs              762                21    97.24%          56                 1    98.21%         402                 4    99.00%           0                 0         -
jetdb/src/format.rs                616                 2    99.68%          45                 0   100.00%         388                 2    99.48%           0                 0         -
jetdb/src/lib.rs                     3                 0   100.00%           1                 0   100.00%           3                 0   100.00%           0                 0         -
jetdb/src/macro_action.rs          299                19    93.65%          27                 3    88.89%         165                24    85.45%           0                 0         -
jetdb/src/macro_def.rs            2440                88    96.39%         196                 9    95.41%        1596                36    97.74%           0                 0         -
jetdb/src/macro_text.rs            804                24    97.01%          54                 2    96.30%         451                20    95.57%           0                 0         -
jetdb/src/map.rs                   416                13    96.88%          27                 0   100.00%         221                 5    97.74%           0                 0         -
jetdb/src/money.rs                 281                 0   100.00%          26                 0   100.00%         186                 0   100.00%           0                 0         -
jetdb/src/prop.rs                 1375                18    98.69%          90                 0   100.00%         695                10    98.56%           0                 0         -
jetdb/src/query.rs                2514                62    97.53%         200                 1    99.50%        1550                18    98.84%           0                 0         -
jetdb/src/relationship.rs          249                26    89.56%          22                 0   100.00%         177                10    94.35%           0                 0         -
jetdb/src/save_as_text.rs          574                27    95.30%          52                 3    94.23%         341                27    92.08%           0                 0         -
jetdb/src/storage.rs               764                32    95.81%          57                 0   100.00%         434                 6    98.62%           0                 0         -
jetdb/src/table.rs                1679                67    96.01%         109                 2    98.17%        1017                18    98.23%           0                 0         -
jetdb/src/timestamp.rs             405                 0   100.00%          44                 0   100.00%         235                 0   100.00%           0                 0         -
jetdb/src/vba.rs                   649                57    91.22%          62                12    80.65%         354                23    93.50%           0                 0         -
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                            37079              1217    96.72%        2679                75    97.20%       21150               542    97.44%           0                 0         -

@dominion525
dominion525 merged commit 72f117e into main Oct 26, 2026
11 checks passed
@dominion525
dominion525 deleted the refactor/wasm branch October 26, 2026 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3ABE Development

Successfully merging this pull request may close these issues.

1 participant

0