Repository navigation
Conversation
…ke message fails to decode
Member
|
beep boop, agent be gone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #651.
When a gateway message fails to decode,
parseMessagelogs the error and returns a nil message, andlistenjust moves on to the next message. That is fine for regular events, but if READY is the one that fails, the shard ends up half-connected:Openblocks until its context ends, since the status only becomes Ready for a decoded EventReady, while holding the identify bucket (blocking the other shards in that bucket too)This PR makes
listentreat a nil message as fatal while the gateway is not ready yet: it callsreadywith an error and returns, so the pendingOpenfails immediately and the normal error path (close + reconnect with a fresh session) takes over, instead of waiting forever for a READY that will never decode.Once ready, nil messages keep being skipped as before, so regular event decode errors don't reconnect the shard.
Tests
Added
gateway/gateway_nil_message_test.go:listenwith an error instead of looping (the scenario from the issue)go build ./...,go vet ./gatewayandgo test ./gateway -raceall pass.