Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
gatewayHandlerGuildStickersUpdatedispatches the sticker lifecycle events but never updates the sticker cache, so the cached stickers for a guild stay frozen at whateverGUILD_CREATEpopulated: stickers created afterwards are missing from the cache, edited ones keep stale values, and deleted ones remain cached until the nextGUILD_CREATE.The sibling
gatewayHandlerGuildEmojisUpdateperforms the same create/update/delete diff and callsAddEmoji/RemoveEmojibefore dispatching each event; the stickers handler is a copy-paste of it with the cache calls dropped. It also kept the loop variable namedemojiover sticker maps.Changes
Mirror the emojis handler in
bot/handlers/guild_stickers_update_handler.go:AddSticker(sticker)before dispatchingStickerCreate.AddSticker(sticker.new)before dispatchingStickerUpdate.RemoveSticker(event.GuildID, sticker.ID)before dispatchingStickerDelete.emojiloop variables tosticker.No behaviour change for consumers who disable
cache.FlagStickers, since the handler already returns before this block.Verification
go build ./...passes.go vet ./bot/...passes.go test ./bot/...: thebotandbot/handlerspackages contain no test files, so there is nothing to run there; the rest of the repository is unaffected by this handler-only change.