Repository navigation
Conversation
Co-authored-by: topi314 <15636011+topi314@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix nil pointer dereference in gateway listen during EventResumed
Guard nil SessionID when logging EventResumed in gateway listener
Oct 23, 2026
vmphase
reviewed
Oct 23, 2026
Comment on lines
+659
to
+663
| sessionID := "" | ||
| if g.config.SessionID != nil { | ||
| sessionID = *g.config.SessionID | ||
| } | ||
| g.config.Logger.Debug("successfully resumed", slog.String("session_id", sessionID)) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: topi314 <15636011+topi314@users.noreply.github.com>
Member
|
why copilot so useless kek |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gatewayImpl.listendereferencesg.config.SessionIDwhen logging aRESUMEDevent. After an Invalid Session (canResume == false) clears resume state, a lateRESUMEDcan arrive whileSessionIDisnil. The dereference then panics and crashes the host process.gateway/gateway.go): theEventResumedbranch now logs an emptysession_idwhenSessionIDisnil. The status transition toStatusReadyand theready(nil)call are unchanged.Not addressed
recover()barrier inlisten(). I left it out because it would hide other bugs. Say if you want it added.resume()dereferencesSessionIDandLastSequenceReceivedwithout a nil check. I didn't confirm the guard at line 225 covers every path into it.