8000 fix: remove busy-wait loop in server startup select by alexferl · Pull Request #174 · alexferl/zerohttp · GitHub
[go: up one dir, main page]

Skip to content

fix: remove busy-wait loop in server startup select - #174

Merged
alexferl merged 1 commit into
masterfrom
fix_spin
May 8, 2026
Merged

alexferl merged 1 commit into
masterfrom
fix_spin

Conversation

@alexferl
@alexferl alexferl commented May 8, 2026
Copy link
Copy Markdown
Owner

The for-select around errCh/startupHookErrCh would spin when channels closed or delivered zero values. Replace with a single select that blocks on both channels deterministically.

The for-select around errCh/startupHookErrCh would spin when channels
closed or delivered zero values. Replace with a single select that
blocks on both channels deterministically.

Signed-off-by: alexferl <me@alexferl.com>
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 25532252670

Coverage remained the same at 93.954%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 2 uncovered changes across 1 file (16 of 18 lines covered, 88.89%).
  • 5 coverage regressions across 1 file.

Uncovered Changes

File Changed Covered %
server.go 18 16 88.89%

Coverage Regressions

5 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
server_tls.go 5 88.24%

Coverage Stats

Coverage Status
Relevant Lines: 11330
Covered Lines: 10645
Line Coverage: 93.95%
Coverage Strength: 209.1 hits per line

💛 - Coveralls

@alexferl
alexferl merged commit c5a5e0d into master May 8, 2026
9 checks passed
@alexferl
alexferl deleted the fix_spin branch May 8, 2026 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0