Repository navigation
Add OGS automatch opponent rank-range controls - #237
Open
eduardoSantiag0 wants to merge 1 commit into
Open
eduardoSantiag0 wants to merge 1 commit into
eduardoSantiag0 wants to merge 1 commit into
Conversation
When finding a game on OGS, the user can now pick how many ranks
stronger and weaker an opponent may be, instead of always using OGS's
default difference of 3. The two values map directly to the
`upper_rank_diff` / `lower_rank_diff` fields of the `automatch/find_match`
request.
- `AutomatchOptions` value object plus an `OGSAutomatch` interface with a
new `findMatch(presetId, options)` entry point. `GameClient.findGame`
is unchanged, so other servers (Fox, Tygem) and their private
submodules are unaffected; `findGame` and `findMatch` share a private
`_startAutomatch` helper.
- `AutomatchRankRangeField` shows two dropdowns ("Stronger" +N /
"Weaker" -N) and, when the player's OGS rank is known, the resulting
absolute rank range. It is only rendered on the lobby for clients that
implement `OGSAutomatch`.
- Selected values are persisted in settings and passed to `AutomatchPage`
via `AutomatchRouteArguments`; defaults (3/3) reproduce the previous
request byte-for-byte.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012jt4kMFeVqSKLVsPuMhKUs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Player can now choose how many ranks stronger and weaker an opponent, instead of always using OGS's default. The two values map to
upper_rank_diff/lower_rank_difffields of theautomatch/find_matchrequest.AutomatchOptionsvalue object plus anOGSAutomatchinterface with a newfindMatch(presetId, options)entry point.GameClient.findGameis unchanged, so other servers (Fox, Tygem) and their private submodules are unaffected;findGameandfindMatchshare a private_startAutomatchhelper.AutomatchRankRangeFieldshows two dropdowns ("Stronger" +N / "Weaker" -N)AutomatchPageviaAutomatchRouteArguments; defaults (3/3) reproduce the previous request byte-for-byte.