8000 Use new plugin API from QE app by edan-bainglass · Pull Request #17 · aiidalab/aiidalab-qe-hp · GitHub
[go: up one dir, main page]

Skip to content

Use new plugin API from QE app - #17

Merged
edan-bainglass merged 1 commit into
mainfrom
new-app-api
Nov 14, 2026
Merged

edan-bainglass merged 1 commit into
mainfrom
new-app-api

Conversation

@edan-bainglass
@edan-bainglass edan-bainglass commented Nov 11, 2026 •
Copy link
Copy Markdown
Member

This PR updates the app w.r.t a new plugin API provided by the app aiming to make much of plugin inner workings lazy to the app, to prevent degrading UX due to external developments.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@edan-bainglass
Copy link
Copy Markdown
Member Author

@cpignedoli test fails because the app PR has to first merge into main. The test installs the app from main in CI.

@AndresOrtegaGuerrero AndresOrtegaGuerrero left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cpignedoli cpignedoli left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on 12–13 November in the isolated ARM64 AiiDAlab environment with Python 3.12, aiida-core 2.9.4 and aiida-quantumespresso 5.1.0.

@edan-bainglass, the fresh LiCoO2 Hubbard calculation completed successfully through QeAppWorkChain, with all 36 processes finishing successfully. Safari checks passed for the Hubbard table, 3D structure and inter-site row selection/highlighting.

The API migration passes in the integrated environment. CI currently fails during collection because its QE main dependency has yet to receive QeAppPlugin from aiidalab/aiidalab-qe#1610. Please rerun it after that merge.

Testing and review performed with Codex assistance.

@edan-bainglass
Copy link
Copy Markdown
Member Author

The API migration passes in the integrated environment. CI currently fails during collection because its QE main dependency has yet to receive QeAppPlugin from aiidalab/aiidalab-qe#1610. Please rerun it after that merge.

Thanks @cpignedoli. I successfully tested the branch locally. I'll go ahead and merge with the failed test, so that we can proceed to pin this minimum version in the app plugin registry.

@edan-bainglass
edan-bainglass merged commit f1391ac into main Nov 14, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0