8000 Support aiida-quantumespresso v5 by edan-bainglass · Pull Request #16 · aiidalab/aiidalab-qe-hp · GitHub
[go: up one dir, main page]

Skip to content

Support aiida-quantumespresso v5 - #16

Merged
edan-bainglass merged 9 commits into
mainfrom
aiida-qe-v5-support
Sep 30, 2026
Merged

edan-bainglass merged 9 commits into
mainfrom
aiida-qe-v5-support

Conversation

@edan-bainglass
@edan-bainglass edan-bainglass commented Sep 29, 2026 •
Copy link
Copy Markdown
Member

Pinning to upcoming aiida-hubbard v0.7.0, accepting patches only.

Pinning to upcoming aiida-hubbard v0.7.0, accepting patches only.
Temporary, until we release. Note that we still need to pin to the repo,
at least until the wannier90 PyPI issue are resolved.
@edan-bainglass
edan-bainglass force-pushed the aiida-qe-v5-support branch 2 times, most recently from 58fe71b to e1a8d6a Compare September 29, 2026 13:43
@edan-bainglass
Copy link
Copy Markdown
Member Author

@cpignedoli while reviewing, do mind the temporary bits. I'll revert and correct once appropriate 🙂

@cpignedoli
Copy link
Copy Markdown
Member

Thanks, @edan-bainglass—understood about the temporary dependency references.

I reviewed 0ffed2e against the aiida-hubbard revision used by CI. The base_init_relax / base_relax migration looks correct: resource settings and advanced overrides reach both relaxation stages, and one-shot mode still removes relaxation and disables the self-consistency loop.

The two repository tests and 14 additional builder checks passed locally with Python 3.12, AiiDA 2.9.2 and aiida-quantumespresso 5.1.0, including construction through the host QeAppWorkChain. No scientific calculations were submitted.

One non-blocking suggestion: parameterize the builder test over both one-shot and self-consistent, since it now exercises only the latter. Using distinct resource values would also make it clearer that the selected settings are forwarded correctly.

No blocking findings from this review. Once the temporary references are replaced with the intended release dependencies, we can recheck the final diff and CI before approval.

@edan-bainglass
edan-bainglass commented Sep 30, 2026 •
Copy link
Copy Markdown
Member Author

One non-blocking suggestion: parameterize the builder test over both one-shot and self-consistent, since it now exercises only the latter. Using distinct resource values would also make it clearer that the selected settings are forwarded correctly.

Good suggestion. Added!

No blocking findings from this review. Once the temporary references are replaced with the intended release dependencies, we can recheck the final diff and CI before approval.

Thanks @cpignedoli. aiida-hubbard 0.7.0 released and bumped here. I'm leaving the main pin for aiidalab-qe in the CI testing for now. We can pin to the new QE app release once done. Note that we cannot remove the pin due to the Wannier90 issues, which prevent us in the time being from publishing the app to PyPI 🥲

@edan-bainglass
edan-bainglass merged commit 4ea29ef into main Sep 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0