8000 Fix File Manager and Tasks links for nbclassic by cpignedoli · Pull Request #278 · aiidalab/aiidalab-home · GitHub
[go: up one dir, main page]

Skip to content

Fix File Manager and Tasks links for nbclassic - #278

Merged
yakutovicha merged 2 commits into
mainfrom
fix/classic-navigation
Nov 16, 2026
Merged

yakutovicha merged 2 commits into
mainfrom
fix/classic-navigation

Conversation

@cpignedoli
@cpignedoli cpignedoli commented Nov 11, 2026 •
Copy link
Copy Markdown
Member

File Manager and Tasks currently link to /tree, which belongs to Notebook 7 when it is installed alongside nbclassic. Resolve these shortcuts with nbclassic_path() so they open the classic UI, including on JupyterHub under /user/<name>/. The terminal and other app links retain their existing routes.

Adds four URL regression cases and browser regression checks for File Manager and Tasks. Updates the existing File Manager test to use the classic Running and Files tabs. Existing formatting is preserved; the diff is limited to the shortcuts and their tests.

Related: aiidalab/aiidalab-docker-stack#621. The companion aiidalab/aiidalab-docker-stack#622 disables the Notebook 7 frontend extension so the terminal also receives the classic branding and session-timer customization. This Home fix can be released first, then consumed by the Docker image.

Validation:

  • Four URL regression cases pass, covering root and Hub base paths with both classic URL layouts.
  • In an integrated local ARM64 preview based on full-stack 2026.1032, manual Chrome checks passed for Home, File Manager, Tasks and Terminal through JupyterHub 5.3.0.
  • Edan's unchanged timer from Bump QE image to v26.11.1 aiidalab-demo-server#97 was visible and counting down on all four pages; Carlo also checked the preview.
  • Full CI run #990 passes: pre-commit, package tests, and browser tests in Chrome and Firefox.

Prepared with the assistance of Codex.

@yakutovicha yakutovicha left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks good 👍

@yakutovicha
yakutovicha marked this pull request as ready for review November 16, 2026 10:40
@edan-bainglass edan-bainglass left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cpignedoli. LGTM! Some of these tests I would argue should've existed already and perhaps should be separated to another PR, but given that we are moving to JL, let's just proceed to deploy and develop 🙂

@yakutovicha
yakutovicha merged commit 72fbfbb into main Nov 16, 2026
5 checks passed
@yakutovicha
yakutovicha deleted the fix/classic-navigation branch November 16, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0