Repository navigation
Fix File Manager and Tasks links for nbclassic - #278
Merged
Merged
Conversation
edan-bainglass
requested review from
danielhollas,
edan-bainglass and
yakutovicha
November 11, 2026 10:51
yakutovicha
marked this pull request as ready for review
November 16, 2026 10:40
edan-bainglass
approved these changes
Nov 16, 2026
Member
There was a problem hiding this comment.
Thanks @cpignedoli. LGTM! Some of these tests I would argue should've existed already and perhaps should be separated to another PR, but given that we are moving to JL, let's just proceed to deploy and develop 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File Manager and Tasks currently link to
/tree, which belongs to Notebook 7 when it is installed alongside nbclassic. Resolve these shortcuts withnbclassic_path()so they open the classic UI, including on JupyterHub under/user/<name>/. The terminal and other app links retain their existing routes.Adds four URL regression cases and browser regression checks for File Manager and Tasks. Updates the existing File Manager test to use the classic Running and Files tabs. Existing formatting is preserved; the diff is limited to the shortcuts and their tests.
Related: aiidalab/aiidalab-docker-stack#621. The companion aiidalab/aiidalab-docker-stack#622 disables the Notebook 7 frontend extension so the terminal also receives the classic branding and session-timer customization. This Home fix can be released first, then consumed by the Docker image.
Validation:
Prepared with the assistance of Codex.