Repository navigation
Implement StatusOverviewWidget - #239
Conversation
95fb1eb to
110e1f2
Compare
| sanitized = _sanitize_broker_url(str(broker)) | ||
| return self._status_row("ok", "broker", sanitized, tooltip=sanitized) | ||
|
|
||
| def _probe_daemon(self): |
There was a problem hiding this comment.
@danielhollas, just a small heads-up: since you asked to display information about the workers' CPU utilization.
I intend to add this to the DaemonControlWidget -- see the class placeholder above ⬆️.
|
@yakutovicha I created a new profile ( |
Yes, this is a bit tricky cause AiiDA's Maybe a flag message that says something like "Hey, the default profile has changed, please reload the page" would be a good solution to this? |
I suppose so, if there is no way to do it dynamically. Note that there have been discussions in the aiida-core team regarding "better" handling of profiles. I'll bring this issue up there. Though I'm not sure I fully understand it 😅 |
get_profile() never picks up a default changed externally (e.g. via `verdi profile setdefault`), since AiiDA's config is cached per process. _probe_profile now reads the on-disk default directly and shows a warning row when it no longer matches the loaded profile, instead of silently displaying stale info.
|
Changed in afd0462. |
There was a problem hiding this comment.
@yakutovicha nice!
I would keep it general though - "Change of profile detected - reload the page to apply". You never know what people name their profiles. For example, suppose you're switching from alice to bob. Your message would be "alice is now bob - reload the page to apply". Fun, but maybe we avoid this via the general message 🙂
Anyhow, just nitpicking now - feel free to proceed as is.
There was a problem hiding this comment.
Thanks! I don't have time to test this properly this week but trust @edan-bainglass so fine with me to go ahead! I have just some minor nits, feel free to ignore.
Also, should this tab be called "AiiDA status"?
|
Just a note that I support all of @danielhollas's comments above 🙂 |
applied in c14b921 |
Since _STATE_COLORS and _ROW_ICONS correspond to the same states, it makes more sense to bring them together under one class.
_probe_version -> _get_aiida_version _probe_config -> _get_config_dir
for more information, see https://pre-commit.ci
|
Thanks @yakutovicha. Good to go 👍 |
fixes #233