8000 Implement `StatusOverviewWidget` by yakutovicha · Pull Request #239 · aiidalab/aiidalab-home · GitHub
[go: up one dir, main page]

Skip to content

Implement StatusOverviewWidget - #239

Merged
yakutovicha merged 21 commits into
mainfrom
233-feature/implement-status-overview-section
Aug 19, 2026
Merged

yakutovicha merged 21 commits into
mainfrom
233-feature/implement-status-overview-section

Conversation

@yakutovicha
Copy link
Copy Markdown
Member

fixes #233

@yakutovicha
yakutovicha requested review from danielhollas and edan-bainglass and a lite review from Copilot and removed request for Copilot and danielhollas August 19, 2026 08:36
Comment thread home/control.py
sanitized = _sanitize_broker_url(str(broker))
return self._status_row("ok", "broker", sanitized, tooltip=sanitized)

def _probe_daemon(self):
@yakutovicha yakutovicha Aug 19, 2026 •
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielhollas, just a small heads-up: since you asked to display information about the workers' CPU utilization.

I intend to add this to the DaemonControlWidget -- see the class placeholder above ⬆️.

@edan-bainglass
Copy link
Copy Markdown
Member

@yakutovicha I created a new profile (presto) and hit refresh. The panel does not reflect the new profile. Changes to the daemon are correctly reflected within a given profile.

@yakutovicha
Copy link
Copy Markdown
Member Author

@yakutovicha I created a new profile (presto) and hit refresh. The panel does not reflect the new profile. Changes to the daemon are correctly reflected within a given profile.

Yes, this is a bit tricky cause AiiDA's get_profile() still has the old profile loaded. So technically, the output IS correct, and the old profile is still loaded in the Python kernel.

Maybe a flag message that says something like "Hey, the default profile has changed, please reload the page" would be a good solution to this?

@edan-bainglass
Copy link
Copy Markdown
Member

@yakutovicha I created a new profile (presto) and hit refresh. The panel does not reflect the new profile. Changes to the daemon are correctly reflected within a given profile.

Yes, this is a bit tricky cause AiiDA's get_profile() still has the old profile loaded. So technically, the output IS correct, and the old profile is still loaded in the Python kernel.

Maybe a flag message that says something like "Hey, the default profile has changed, please reload the page" would be a good solution to this?

I suppose so, if there is no way to do it dynamically. Note that there have been discussions in the aiida-core team regarding "better" handling of profiles. I'll bring this issue up there. Though I'm not sure I fully understand it 😅

get_profile() never picks up a default changed externally (e.g. via
`verdi profile setdefault`), since AiiDA's config is cached per
process. _probe_profile now reads the on-disk default directly and
shows a warning row when it no longer matches the loaded profile,
instead of silently displaying stale info.
@yakutovicha
Copy link
Copy Markdown
Member Author

@edan-bainglass

image

Changed in afd0462.

@edan-bainglass edan-bainglass left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yakutovicha nice!

I would keep it general though - "Change of profile detected - reload the page to apply". You never know what people name their profiles. For example, suppose you're switching from alice to bob. Your message would be "alice is now bob - reload the page to apply". Fun, but maybe we avoid this via the general message 🙂

Anyhow, just nitpicking now - feel free to proceed as is.

@danielhollas danielhollas left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I don't have time to test this properly this week but trust @edan-bainglass so fine with me to go ahead! I have just some minor nits, feel free to ignore.

Also, should this tab be called "AiiDA status"?

Comment thread home/control.py Resolved
Comment thread home/control.py Resolved
Comment thread home/control.py Resolved
@edan-bainglass
Copy link
Copy Markdown
Member

Just a note that I support all of @danielhollas's comments above 🙂

@yakutovicha
Copy link
Copy Markdown
Member Author

@yakutovicha nice!

I would keep it general though - "Change of profile detected - reload the page to apply". You never know what people name their profiles. For example, suppose you're switching from alice to bob. Your message would be "alice is now bob - reload the page to apply". Fun, but maybe we avoid this via the general message 🙂

Anyhow, just nitpicking now - feel free to proceed as is.

applied in c14b921

yakutovicha and others added 4 commits August 19, 2026 13:07
Since _STATE_COLORS and _ROW_ICONS correspond to the same states,
it makes more sense to bring them together under one class.
_probe_version -> _get_aiida_version
_probe_config -> _get_config_dir
@edan-bainglass
Copy link
Copy Markdown
Member

Thanks @yakutovicha. Good to go 👍

@yakutovicha
yakutovicha merged commit 8f31fa9 into main Aug 19, 2026
5 checks passed
@yakutovicha
yakutovicha deleted the 233-feature/implement-status-overview-section branch August 19, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Control page: implement the Status overview section

3 participants

0