Repository navigation
8000
Report unknown app compatibility as None instead of False - #563
Draft
danielhollas wants to merge 1 commit into
Draft
danielhollas wants to merge 1 commit into
danielhollas wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #563 +/- ##
==========================================
+ Coverage 81.16% 81.20% +0.03%
==========================================
Files 18 18
Lines 1895 1899 +4
==========================================
+ Hits 1538 1542 +4
Misses 357 357
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
danielhollas
force-pushed
the
claude-fix-3
branch
from
October 19, 2026 08:06
01c5be6 to
46eb353
Compare
danielhollas
force-pushed
the
claude-fix-3
branch
from
October 19, 2026 08:39
46eb353 to
da89bdb
Compare
Don't check compatibility of apps that are not installed, and return None when the installed version is not a registry release. Previously both cases set `compatible` to False, so the home app showed every uninstalled app as incompatible. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
danielhollas
force-pushed
the
claude-fix-3
branch
from
October 26, 2026 19:37
da89bdb to
ec090eb
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DH: This is pure Claude for now, need to check this and verify against aiidalab-home
Fixes item 5 from #559
Don't check compatibility of apps that are not installed, and return None when the installed version is not a registry release. Previously both cases set
compatibleto False, so the home app showed every uninstalled app as incompatible.