8000 Report unknown app compatibility as None instead of False by danielhollas · Pull Request #563 · aiidalab/aiidalab · GitHub
[go: up one dir, main page]

Skip to content
8000

Report unknown app compatibility as None instead of False - #563

Draft
danielhollas wants to merge 1 commit into
mainfrom
claude-fix-3
Draft

danielhollas wants to merge 1 commit into
mainfrom
claude-fix-3

Conversation

@danielhollas
@danielhollas danielhollas commented Oct 18, 2026 •
Copy link
Copy Markdown
Contributor

DH: This is pure Claude for now, need to check this and verify against aiidalab-home

Fixes item 5 from #559


Don't check compatibility of apps that are not installed, and return None when the installed version is not a registry release. Previously both cases set compatible to False, so the home app showed every uninstalled app as incompatible.

@danielhollas
danielhollas added this pull request to stack #562 October 18, 2026 23:17
@codecov
codecov Bot commented Oct 18, 2026 •
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.20%. Comparing base (94337c4) to head (ec090eb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
+ Coverage   81.16%   81.20%   +0.03%     
==========================================
  Files          18       18              
  Lines        1895     1899       +4     
==========================================
+ Hits         1538     1542       +4     
  Misses        357      357              
Flag Coverage Δ
py-3.12 81.14% <100.00%> (-0.02%) ⬇️
py-3.14 81.12% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Don't check compatibility of apps that are not installed, and return
None when the installed version is not a registry release. Previously
both cases set `compatible` to False, so the home app showed every
uninstalled app as incompatible.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@danielhollas danielhollas added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Oct 26, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0