8000 Add timeout to HTTPS archive downloads by danielhollas · Pull Request #565 · aiidalab/aiidalab · GitHub
[go: up one dir, main page]

Skip to content

Add timeout to HTTPS archive downloads - #565

Open
danielhollas wants to merge 1 commit into
claude-fix-4from
claude-fix-5
Open

danielhollas wants to merge 1 commit into
claude-fix-4from
claude-fix-5

Conversation

@danielhollas
@danielhollas danielhollas commented Oct 18, 2026 •
Copy link
Copy Markdown
Contributor

requests.get() has no default timeout, so a server that stopped responding would hang app installation indefinitely. Use a 60 s timeout for connecting and for each read, which still allows slow downloads of large archives. https://requests.readthedocs.io/en/latest/user/advanced/#timeouts

Also drop stream=True, which had no effect since the full response content was read into memory anyway. https://requests.readthedocs.io/en/latest/user/advanced/#body-content-workflow.

@danielhollas
danielhollas added this pull request to stack #562 October 18, 2026 23:45
@codecov
codecov Bot commented Oct 18, 2026 •
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.25%. Comparing base (d2a4e13) to head (620d686).

Additional details and impacted files
@@              Coverage Diff              @@
##           claude-fix-4     #565   +/-   ##
=============================================
  Coverage         81.25%   81.25%           
=============================================
  Files                18       18           
  Lines              1904     1905    +1     
=============================================
+ Hits               1547     1548    +1     
  Misses              357      357           
Flag Coverage Δ
py-3.12 81.25% <100.00%> (+0.06%) ⬆️
py-3.14 81.18% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@edan-bainglass edan-bainglass left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

requests.get() has no default timeout, so a server that stopped
responding would hang app installation indefinitely. Use a 60 s timeout
for connecting and for each read, which still allows slow downloads of
large archives.

Also drop stream=True, which had no effect since the full response
content was read into memory anyway
@danielhollas danielhollas added the enhancement New feature or request label Oct 26, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0