8000 Don't try to read citations from setup.cfg metadata section by danielhollas · Pull Request #540 · aiidalab/aiidalab · GitHub
[go: up one dir, main page]

Skip to content

Don't try to read citations from setup.cfg metadata section - #540

Merged
danielhollas merged 2 commits into
mainfrom
citations-from-metadata
Sep 30, 2026
Merged

danielhollas merged 2 commits into
mainfrom
citations-from-metadata

Conversation

@danielhollas
Copy link
Copy Markdown
Contributor

citations field is specific to AiiDAlab so it will only ever be present in the aiidalab section of the setup.cfg file. setuptools would probably complain if one tried to put it in its metadata section.

Also added logging for when citation's json parsing fails.

@codecov
codecov Bot commented Sep 29, 2026 •
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.39%. Comparing base (663f9d4) to head (054247a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #540      +/-   ##
==========================================
+ Coverage   74.35%   74.39%   +0.04%     
==========================================
  Files          18       18              
  Lines        1735     1738       +3     
==========================================
+ Hits         1290     1293       +3     
  Misses        445      445              
Flag Coverage Δ
py-3.12 74.39% <100.00%> (+0.04%) ⬆️
py-3.9 74.39% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danielhollas
danielhollas added this pull request to stack #541 September 29, 2026 19:14
Comment thread aiidalab/metadata.py
categories = [c for c in categories.split("\n") if c]

citation_string = aiidalab.get("citations", metadata_pep426.get("citations"))
citation_string = aiidalab.get("citations", "[]")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danielhollas. I wasn't thinking carefully here. Indeed, citations are non-standard.

@edan-bainglass edan-bainglass left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for catching that 🙂

Base automatically changed from cleanup-citations to main September 30, 2026 10:08
@danielhollas
danielhollas force-pushed the citations-from-metadata branch from 99131d8 to 054247a Compare September 30, 2026 10:08
@danielhollas
danielhollas merged commit 1a2f10c into main Sep 30, 2026
9 checks passed
@danielhollas
danielhollas deleted the citations-from-metadata branch September 30, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0