You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Utilize the exiting SimpleCitation and StandardCitation dataclasses as a very rudimentary validation of the citations data parsed from setup.cfg. This at the very least ensures that all mandatory fields are present.
I originally wanted to convert the types to these dataclasses as well, but that doesn't quite work, as the bots have pointed out (see Copilot comments below)
The SimpleCitation exception is discarded, so every malformed simple citation is diagnosed using the unrelated StandardCitation failure. For the new test's second entry, the actual unsupported invalid field is hidden and the log instead claims that text is unexpected. Dispatch using the citation-shape marker or include both validation failures so the warning identifies the real problem.
Remove redundant duplicate assertion
tests/test_metadata.py:285
This repeats the assertion already made on line 281, so it does not add coverage and can be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Utilize the exiting
SimpleCitationandStandardCitationdataclasses as a very rudimentary validation of the citations data parsed fromsetup.cfg. This at the very least ensures that all mandatory fields are present.I originally wanted to convert the types to these dataclasses as well, but that doesn't quite work, as the bots have pointed out (see Copilot comments below)