Repository navigation
docs: describe and test issuer filters for vault_iota - #269
Merged
Merged
Conversation
|
Coverage after merging issuer-object-form into main will be
Coverage Report |
soroush-y
marked this pull request as ready for review
October 13, 2026 08:25
|
Coverage after merging issuer-object-form into main will be
Coverage Report |
andrew-aff
previously approved these changes
Oct 13, 2026
There was a problem hiding this comment.
Review, round 1
🟡 Some things to fix
Looked at b5be1eb: 5 need attention.
Needs attention (5)
- 🟠 Worth changing: README calls the path order an engine quirk, the PE spec requires it · New
- 🟠 Worth changing: No IDV routing test with a pattern issuer filter · New
- 🟠 Worth changing: The two README warnings have no tests · New
- 🔵 Minor: Section heading sits above the wrong group · New
- 🔵 Minor: DID is not regex-escaped in the fixture pattern · New
Questions (1)
|
Coverage after merging issuer-object-form into main will be
Coverage Report |
earl-affinidi
previously approved these changes
Oct 13, 2026
earl-affinidi
approved these changes
Oct 13, 2026
|
Coverage after merging issuer-object-form into main will be
Coverage Report |
🛡️ AI Agentic Security Code Review🔎 A manual security review is recommended before merging. Please contact the Security team for specifics and remediation guidance.
|
IVIR3zaM
previously approved these changes
Oct 14, 2026
reza-maghoul-affinidi
dismissed
IVIR3zaM’s stale review
October 14, 2026 07:36
Approval posted from personal account by mistake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: documents and tests the issuer filters that match both string and object issuers in vault_iota.
$.issuer.idfirst) and DCQLclaim_setsshape.{"id": ...}issuers withconstandpatternfilters, plus a different-DID negative.issuerAsObjectoption tobuildTestVcand anissuerPathsoption tobuildDescriptor, and makesbuildDescriptor'susePatterncover the issuer filter; defaults are unchanged.ssilibrary use the object form, which a$.issuer-only string filter never matches.