Repository navigation
feat: manage mediator access lists via Trust Tasks - #268
Merged
Merged
Conversation
TrustTaskMessage, AccessListUpdateTask and MediatorClient.sendTrustTask first ship in didcomm 2.4.0; with ^2.3.4 the mediator client, atlas client and integration tests fail to resolve them.
Affinidi mediators 0.31 and later removed the mediator/1.0/acl-management protocol and answer it with 501. Point callers to the Trust Tasks sent via DidcommMediatorClient.sendTrustTask, since this package hides MediatorClient from its exports.
The acl-management message used by configureAcl is rejected by mediators 0.31 and later, failing the mediator client, VDSP and VDIP integration test setup.
Show AccessListUpdateTask with sendTrustTask instead of the deprecated acl-management message. Mediators 0.25 and later answer every refusal with the same delivery.refused problem report, so the example accepts it and notes that it cannot single out access-list denials.
Atlas client init sends the acl-management message, which mediators 0.31 and later reject with 501, so initialisation fails against them.
ivan-branets-affinidi
previously approved these changes
Oct 12, 2026
marco-a-affinidi
previously approved these changes
Oct 14, 2026
CI's TEST_MEDIATOR_DID still points to a pre-0.31 mediator that does not support Trust Tasks. TEST_TRUST_TASKS_MEDIATOR_DID lets CI target a newer mediator temporarily without breaking branches that still use it.
maindotdev
dismissed stale reviews from marco-a-affinidi and ivan-branets-affinidi
via
October 16, 2026 09:14
3e65fbe
|
Coverage after merging feat/mediator-trust-tasks into main will be
Coverage Report |
1 similar comment
|
Coverage after merging feat/mediator-trust-tasks into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
🛡️ AI Agentic Security Code Review1 finding needs a human to review/validate. Mandatory to check: 🔒 Security Code Review Report — Security tab ↗ 📊 Summary & findings
Finding details (titles, evidence + remediation) are in the 🔒 Security tab ↗ — visible to maintainers / code owners only. |
ivan-branets-affinidi
approved these changes
Oct 16, 2026
marco-a-affinidi
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affinidi mediators 0.31 and later no longer support the
mediator/1.0/acl-managementprotocol and reject it with501 Not Implemented. This breaks the Atlas client at startup and the setup of the mediator client, VDSP and VDIP integration tests. Access lists are now managed with Trust Tasks (AccessListUpdateTasksent withsendTrustTask), which didcomm 2.4.0 adds.Changes
didcommto^2.4.0inaffinidi_tdk_didcomm_mediator_client.sendAclManagementMessage,AclManagementMessageandAccessListAddMessage, pointing toDidcommMediatorClient.sendTrustTask.TestConfig.configureAclnow usesAccessListUpdateTask, so the integration test setup works against current mediators.acl_example.dartuse Trust Tasks.e.p.delivery.refusedreport, so the example accepts that report.configureAclnow sendsAccessListUpdateTaskinstead of the acl-management message.Compatibility
Dependencies / before merging