Repository navigation
Add Lanes: several Buffers on one group - #32
#32Merged
Etelis merged 2 commits intoNov 15, 2026
Merged
Conversation
Lanes builds one Buffer per lane, checks every rank asks for the same number, and gives each lane its own communication stream, so callers no longer set the stream environment variable themselves. It is set only while the Buffers are constructed and then restored. Signed-off-by: Itay Etelis <92247226+Etelis@users.noreply.github.com>
--lanes N now builds its Buffers through Lanes. Signed-off-by: Itay Etelis <92247226+Etelis@users.noreply.github.com>
Etelis
marked this pull request as ready for review
November 15, 2026 14:22
|
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #31; only the last two commits are new.
What and why
Overlapping exchanges (DBO) needs one
Bufferper lane, and until now the caller had to setAFD_DEEPEP_PER_BUFFER_COMM_STREAM=1before building them.Lanesdoes that for the caller:lanes=1it behaves like a singleBuffer.Which exchange runs on which lane, and the call order, stay with the caller.
The env var is set only while the Buffers are constructed and then restored, because the native code reads it at construction. A constructor flag would be cleaner but is a native change; this PR has none, so the source digest is unchanged.
Checks
python -m pytest tests/unit,ruff check .andruff format --check .pass--lanes 2(BF16 and FP8, hybrid on and off). Not run yet, so this is a draft.Evidence
Pending the GPU run:
EP_DISABLE_GIN=1 torchrun --standalone --nproc-per-node=4 \ -m tests.gpu.deepep --payload fp8 --hybrid off --capacity 32 --lanes 2