Repository navigation
Remove the v1 generation name from the repository - #13
Merged
Merged
Conversation
docs/v1.md is now docs/design.md, and each docs/validation-v1-<name>.json record is docs/validation-<name>.json. Links in the README, docs and templates, cross-references inside the records, the figure data's sources and two comments in afdep_suites.hpp follow. Section headings are unchanged, so every anchor still resolves. The comment edits change only comments; LOCAL_CHANGES.json carries the refreshed file hash.
The README, design doc, notices, provenance text and records call the role path afdEP, the role path or the release instead of v1. The design doc's naming note becomes a digest note: 958652a3 is the tree of commit 32c871d, and the commits after it changed only comments, notices and other text in the native tree (the 1.0.0 release tree is 131efc37). The 8 x H200 and cross-node record names its role arm afd, as the other records do, and the role-suites record names the tree before the suites pre_suites. Tests call the pinned shared-kernel hashes SHARED_KERNEL_SHA256 and drop v1 from a test name. The comment edit in buffer.hpp and the provenance text change only comments and text; the native source digest is now db115728.
benchmarks.json names its role series afdEP, and plot_benchmarks.py uses that label in its legends and subtitles. The regenerated result figures differ from the previous ones only in that text and in the legend's second entry, which moves left by the width of the dropped " v1". The two hand-drawn diagrams change only their title, description and heading text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Removes the "v1" generation name from the repository; the version number (1.0.0, tag
v1.0.0) stays.docs/v1.mdbecomesdocs/design.md(title "afdEP: Masked DeepEP adapted to AFD"; section headings and anchors unchanged), and the 39docs/validation-v1-*.jsonrecords becomedocs/validation-*.json. Every reference is updated: README links and §-anchors,docs/api.md,docs/validation.md, the PR and feature-request templates, cross-references inside the records, thesourcefields indocs/assets/benchmarks.json, and two comments inafdep_suites.hpp.958652a3is the native tree of32c871d; later commits changed only comments, notices and other text in the native tree; the 1.0.0 release tree is131efc37). Test identifiers lose the prefix (SHARED_KERNEL_SHA256,test_public_api_*), with the same behaviour. A few record keys that named the generation are renamed (for example thev1arm invalidation-h200-screens.jsonbecomesafd, as the other records call it); numbers are unchanged.buffer.hppand the "v1:" labels inLOCAL_CHANGES.jsonandPROVENANCE.json. No upstream code changes. The native source digest becomesdb115728(comment and metadata text only); the records keep the digests that were measured.plot_benchmarks.py; the diffs change only label text and the legend shift that follows. The hand-drawn diagrams lose "v1" from their titles.v0anddocs/validation.md/docs/validation-v0.jsonare left as they are.Checks
python -m pytest tests/unit,ruff check .andruff format --check .passEvidence
A link check over 196 references (relative Markdown links,
src/srcset, GitHub heading anchors intodocs/design.md, and everydocs/...path in tracked text files) finds none broken.uv buildplustests/check_distribution.pypass; the sdist holdsdocs/design.mdand the renamed records, and no path containingv1.git grep -ifor v1 finds nothing outside random bytes in the logo PNG.