8000 Remove the v1 generation name from the repository by Etelis · Pull Request #13 · afdEP/afdEP-comm · GitHub
[go: up one dir, main page]

Skip to content

Remove the v1 generation name from the repository - #13

Merged
Etelis merged 3 commits into
mainfrom
drop-v1-name
Oct 24, 2026
Merged

Etelis merged 3 commits into
mainfrom
drop-v1-name

Conversation

@Etelis
@Etelis Etelis commented Oct 24, 2026
Copy link
Copy Markdown
Member

What and why

Removes the "v1" generation name from the repository; the version number (1.0.0, tag v1.0.0) stays.

  • docs/v1.md becomes docs/design.md (title "afdEP: Masked DeepEP adapted to AFD"; section headings and anchors unchanged), and the 39 docs/validation-v1-*.json records become docs/validation-*.json. Every reference is updated: README links and §-anchors, docs/api.md, docs/validation.md, the PR and feature-request templates, cross-references inside the records, the source fields in docs/assets/benchmarks.json, and two comments in afdep_suites.hpp.
  • Wording: "afdEP v1" becomes "afdEP" throughout the docs, README and notices. The design doc's "Naming" paragraph becomes a "Digests" note that states which commit each recorded native digest belongs to (958652a3 is the native tree of 32c871d; later commits changed only comments, notices and other text in the native tree; the 1.0.0 release tree is 131efc37). Test identifiers lose the prefix (SHARED_KERNEL_SHA256, test_public_api_*), with the same behaviour. A few record keys that named the generation are renamed (for example the v1 arm in validation-h200-screens.json becomes afd, as the other records call it); numbers are unchanged.
  • afdEP's own text in the vendored tree is reworded too: one afdEP-added comment in buffer.hpp and the "v1:" labels in LOCAL_CHANGES.json and PROVENANCE.json. No upstream code changes. The native source digest becomes db115728 (comment and metadata text only); the records keep the digests that were measured.
  • Figures: the series is labelled "afdEP" and the SVGs are regenerated with plot_benchmarks.py; the diffs change only label text and the legend shift that follows. The hand-drawn diagrams lose "v1" from their titles.

v0 and docs/validation.md / docs/validation-v0.json are left as they are.

Checks

  • python -m pytest tests/unit, ruff check . and ruff format --check . pass
  • Native changes: the GPU suite on the affected backend (comment and metadata text only; not rerun)
  • Performance claims: none
  • Records and docs/design.md name the exact native source digest measured
  • Optimizations are AFD-specific and keep a control switch: not applicable
  • Communication-only results are labeled as such; no serving claims without serving evidence

Evidence

A link check over 196 references (relative Markdown links, src/srcset, GitHub heading anchors into docs/design.md, and every docs/... path in tracked text files) finds none broken. uv build plus tests/check_distribution.py pass; the sdist holds docs/design.md and the renamed records, and no path containing v1. git grep -i for v1 finds nothing outside random bytes in the logo PNG.

docs/v1.md is now docs/design.md, and each docs/validation-v1-<name>.json
record is docs/validation-<name>.json. Links in the README, docs and
templates, cross-references inside the records, the figure data's sources
and two comments in afdep_suites.hpp follow. Section headings are
unchanged, so every anchor still resolves. The comment edits change only
comments; LOCAL_CHANGES.json carries the refreshed file hash.
The README, design doc, notices, provenance text and records call the
role path afdEP, the role path or the release instead of v1. The design
doc's naming note becomes a digest note: 958652a3 is the tree of commit
32c871d, and the commits after it changed only comments, notices and
other text in the native tree (the 1.0.0 release tree is 131efc37). The
8 x H200 and cross-node record names its role arm afd, as the other
records do, and the role-suites record names the tree before the suites
pre_suites. Tests call the pinned shared-kernel hashes
SHARED_KERNEL_SHA256 and drop v1 from a test name.

The comment edit in buffer.hpp and the provenance text change only
comments and text; the native source digest is now db115728.
benchmarks.json names its role series afdEP, and plot_benchmarks.py
uses that label in its legends and subtitles. The regenerated result
figures differ from the previous ones only in that text and in the
legend's second entry, which moves left by the width of the dropped
" v1". The two hand-drawn diagrams change only their title, description
and heading text.
@Etelis
Etelis requested a review from almogtavor as a code owner October 24, 2026 08:37
@Etelis
Etelis merged commit 7cbd2c6 into main Oct 24, 2026
4 checks passed
@Etelis
Etelis deleted the drop-v1-name branch October 24, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0