Repository navigation
fix(boardservice): let the planning boards remove work the actor carries - #316
Merged
Merged
Conversation
The guard that keeps a person from taking off the board work somebody else planned for them held on every board. On the Team board, where the plan is made, it refused a lead every x on a card in their own column that somebody else had typed: back to the backlog and off the board alike, so the card stayed on the grid after the optimistic patch rolled back. The Me board's own refusal sends the person to the board the work was planned on, which was this one. The guard now applies to the person's own seat only: DELETE, and the remove gesture from the Me board or from no board (view=all). The Team, Backlog and Strategy boards keep the wide x. Assisted-by: LLM Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A team lead planning their team could not take a task off the Team board, to the backlog or off the board, when somebody else had created it: the server answered 403
notYoursToRemove, the board rolled the optimistic change back, and the card stayed where it was.The authorship check is meant for a person's own board, where the answer to work planned for you is to refuse it. The Team, Backlog and Strategy boards are where plans are made, and their × now removes such a card. The Me board,
view=allandDELETE /cards/{uid}keep the check.Row S11,
docs/api.md, OpenAPI and the MCPremove_carddescription are updated.