8000 fix(backend): unverifying and moving report possible as admin by g-kedev · Pull Request #1606 · adfinis/timed · GitHub
[go: up one dir, main page]

Skip to content

fix(backend): unverifying and moving report possible as admin - #1606

Open
g-kedev wants to merge 1 commit into
adfinis:mainfrom
g-kedev:fix/move-and-unverify-as-admin
Open

g-kedev wants to merge 1 commit into
adfinis:mainfrom
g-kedev:fix/move-and-unverify-as-admin

Conversation

@g-kedev
@g-kedev g-kedev commented Nov 10, 2026 •
Copy link
Copy Markdown
Contributor

Ref: #1605

@g-kedev g-kedev self-assigned this Nov 10, 2026
@g-kedev
g-kedev force-pushed the fix/move-and-unverify-as-admin branch from 47aea1e to 8c30eba Compare November 10, 2026 13:27
@g-kedev
g-kedev marked this pull request as ready for review November 10, 2026 13:27
@g-kedev
g-kedev requested a review from a team as a code owner November 10, 2026 13:27
@g-kedev
g-kedev force-pushed the fix/move-and-unverify-as-admin branch from 8c30eba to 4a56a3a Compare November 10, 2026 13:28
@g-kedev g-kedev changed the title fix(backend): unverify and move possible as admin fix(backend): unverifying and moving report possible as admin Nov 10, 2026
@g-kedev
g-kedev requested a review from trowik November 10, 2026 13:29
if is_superuser:
client = superadmin_client
employment_factory(user=client.user)
task1 = task_factory()
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use pytest_lazy_fixtures to switch between types of api_client

see:

(lf("auth_client"), False, status.HTTP_403_FORBIDDEN),

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Done

Comment on lines +2848 to +2849
task1 = task_factory()
task2 = task_factory()
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
task1 = task_factory()
task2 = task_factory()
task1, task2 = task_factory.create_batch(2)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@g-kedev
g-kedev force-pushed the fix/move-and-unverify-as-admin branch from 4a56a3a to 148b835 Compare November 13, 2026 12:28
@trowik
trowik commented Nov 13, 2026
Copy link
Copy Markdown
Member

and rebase the branch :)

@g-kedev
g-kedev force-pushed the fix/move-and-unverify-as-admin branch from 148b835 to 1d0ea48 Compare November 16, 2026 09:00
@trowik trowik left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0