Repository navigation
Conversation
g-kedev
force-pushed
the
fix/move-and-unverify-as-admin
branch
from
November 10, 2026 13:27
47aea1e to
8c30eba
Compare
g-kedev
marked this pull request as ready for review
November 10, 2026 13:27
g-kedev
force-pushed
the
fix/move-and-unverify-as-admin
branch
from
November 10, 2026 13:28
8c30eba to
4a56a3a
Compare
trowik
requested changes
Nov 11, 2026
| if is_superuser: | ||
| client = superadmin_client | ||
| employment_factory(user=client.user) | ||
| task1 = task_factory() |
Member
There was a problem hiding this comment.
use pytest_lazy_fixtures to switch between types of api_client
see:
timed/backend/timed/tracking/tests/test_report.py
Line 2649 in 4c69568
Comment on lines
+2848
to
+2849
| task1 = task_factory() | ||
| task2 = task_factory() |
Member
There was a problem hiding this comment.
Suggested change
| task1 = task_factory() | |
| task2 = task_factory() | |
| task1, task2 = task_factory.create_batch(2) |
g-kedev
force-pushed
the
fix/move-and-unverify-as-admin
branch
from
November 13, 2026 12:28
4a56a3a to
148b835
Compare
trowik
requested changes
Nov 13, 2026
Member
|
and rebase the branch :) |
g-kedev
force-pushed
the
fix/move-and-unverify-as-admin
branch
from
November 16, 2026 09:00
148b835 to
1d0ea48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #1605