Repository navigation
docs: tell the release skill that squash merges drop commit footers - #361
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo setting
squash_merge_commit_messageisBLANK. A squash merge therefore drops theRelease-As:andBREAKING CHANGE:footers of the branch commits, and release-please reads footers only from the commit body.The
releasing-packagesskill now says to give the footer as the body ofgh pr merge, and to check the merged commit. #358 used this method to keep itsRelease-As: 5.0.0footer.Test plan
oxfmt --checkpasses on the skill file.f236dff).