Repository navigation
build: drop tsconfig options that typescript 6 makes default - #353
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes two options from
tsconfig.base.jsonthat have no effect with TypeScript 6. The TypeScript 6.0 release notes describe both changes:"DOM.Iterable"inlib:lib.dom.d.tsnow contains the iterable declarations, anddom.iterableis an empty file."strict": true:strictis nowtrueby default.examples/next/tsconfig.jsonkeeps the same options, because Next.js writes that file.Checklist
nextbranch.!and aBREAKING CHANGE:footer.tsc --noEmitfor thesrcof each package,tsc -p packages/<package>/testfor core, react, react-awesome-reveal and astro,vue-tsc -p testfor vue,tsc -p packages/test-utilsandtsc -p .astro checkinexamples/astro,vue-tscinexamples/vueandtscinexamples/reactpnpm buildfrom a clean state logs no TypeScript diagnostics, and each.d.tsfile indistis byte-identical to the output before this PR.