8000 build(deps-dev): update typescript to 6.0.3 by morellodev · Pull Request #352 · awesome-reveal/awesome-reveal · GitHub
[go: up one dir, main page]
Skip to content

build(deps-dev): update typescript to 6.0.3 - #352

Merged
morellodev merged 5 commits into
nextfrom
build/typescript-6
Oct 25, 2026
Merged

build(deps-dev): update typescript to 6.0.3#352
morellodev merged 5 commits into
nextfrom
build/typescript-6

Conversation

@morellodev
@morellodev morellodev commented Oct 25, 2026 •
edited
Loading
Copy link
Copy Markdown
Collaborator

Summary

This PR updates TypeScript from 5.7.2 to 6.0.3, the latest 6.x release. TypeScript 7 waits until the tools support it. #351 shows that TypeScript 7 breaks CI: it removes the JS API, so vue-tsc fails with ERR_PACKAGE_PATH_NOT_EXPORTED: './lib/tsc', and the builds and astro check fail too.

  • Moves typescript to the pnpm catalog. The root, examples/astro and examples/next use catalog:.
  • Makes Dependabot ignore typescript 7 and later. Remove this rule when vue-tsc, vite-plugin-dts and @astrojs/check support TypeScript 7.
  • Adds allowImportingTsExtensions to the root tsconfig.json. tsc -p . reported TS5097 for the .ts import path in vitest.config.ts, also with TypeScript 5.7.2. The test tsconfigs already set this option, and the base config sets noEmit.

TypeScript 6 changes two defaults that affect the build. The 6.0 release notes list both:

  • noUncheckedSideEffectImports is now true. The compat package type-checks the react sources through the tsconfig paths, but its include did not have packages/react/src/reveal-style.d.ts. In CI, dist does not exist yet, so import "#reveal-style.css" failed with TS2882. Both compat tsconfigs now include the declaration.
  • rootDir is now the tsconfig folder. The paths add the core sources to each adapter, so vite-plugin-dts logged TS6059 for all 4 adapters, but the build did not fail. tsconfig.base.json now sets rootDir to the repo root, which contains all the sources.

The dist output does not change. With TypeScript 6, the build makes the same 49 files, and each .d.ts file is byte-identical to the TypeScript 5.7.2 output.

Checklist

  • The PR targets the next branch.
  • The PR title follows Conventional Commits. A breaking change has ! and a BREAKING CHANGE: footer.
  • Tests cover the change. The existing suites ran wi 8000 th TypeScript 6.0.3, after a removal of all dist folders, as in CI:
    • REVEAL_BROWSERS=chromium pnpm test: 635 passed, 28 skipped, no type errors
    • pnpm test:package: 50 passed, no TypeScript diagnostics in the build log, publint and attw find no problems
    • tsc -p packages/<package>/test for core, react, react-awesome-reveal and astro, tsc -p packages/test-utils, vue-tsc -p test for vue, and tsc -p .
    • astro check in examples/astro, tsc --noEmit in examples/next and examples/react, vue-tsc in examples/vue
    • pnpm lint and pnpm format:check
  • A change to an option, a default or an export also updates the READMEs, the consumer skills and the examples. Does not apply: no option, default or export changes.

@morellodev
morellodev commented Oct 25, 2026
Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 25, 2026 •
edited
Loading
Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T07:45:57.212230Z 64d21f7 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 25, 2026
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 92c794f76c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@morellodev 8000
morellodev commented Oct 25, 2026
Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 25, 2026
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 64d21f7d74

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@morellodev
morellodev merged commit c693f2f into next Oct 25, 2026
19 checks passed
@morellodev
morellodev deleted the build/typescript-6 branch October 25, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@morellodev
0