Repository navigation
test: measure fully minified consumer bundles - #343
Merged
Merged
Conversation
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The size budgets measured Vite library-mode output. For ES output, library mode minifies with
codegen: false, so whitespace and/* @__PURE__ */comments stayed in the bundle. An app build removes them. NowbundleFixturesetsoutput: { minify: true, comments: false }, so it measures what a consumer ships. The fully minified output has no//#regionlines, so the code that stripped them is gone.Each budget is now the next multiple of 10 above the measured size:
revealreveal+cascadeReveal(JS + CSS)useReveal(JS + CSS)Reveal(JS + CSS)vReveal(JS + CSS)The margin is small, so a minifier change in a Vite or Rolldown upgrade can make these tests fail. Then measure again and set new limits.
Checklist
nextbranch.!and aBREAKING CHANGE:footer.pnpm vitest run --project "*:package"passes (50 tests).