8000 build: pin pnpm and node with devEngines by morellodev · Pull Request #342 · awesome-reveal/awesome-reveal · GitHub
[go: up one dir, main page]
Skip to content

build: pin pnpm and node with devEngines - #342

Merged
morellodev merged 2 commits into
nextfrom
build/dev-engines
Oct 23, 2026
Merged

build: pin pnpm and node with devEngines#342
morellodev merged 2 commits into
nextfrom
build/dev-engines

Conversation

@morellodev
@morellodev morellodev commented Oct 23, 2026 •
edited
Loading
Copy link
Copy Markdown
Collaborator

Summary

This PR replaces .nvmrc and the packageManager field with devEngines in the root package.json. pnpm 12 reads it and downloads the declared versions (onFail: "download"). The versions are exact: pnpm 12.15.0 and Node 24.22.1. The lockfile records the Node runtime with its checksums. The root package also loses its engines field: the root is private, and devEngines.runtime pins Node. The published packages keep their engines.

CI and release changes:

  • Each job uses pnpm/setup@v3.1.1 in place of pnpm/action-setup, actions/setup-node and the pnpm install --frozen-lockfile step. The action reads devEngines, installs pnpm and Node, and runs a frozen install (require-lockfile: true).
  • The framework and smoke jobs set save-cache: false. They add packages to the store, so each run would save a new cache entry.
  • The publish job does not cache the pnpm store (cache is false by default). The action always restores and saves its small lockfile verification cache, and no input turns this off.
  • release.yml uses pnpm view in place of npm view, because the Node runtime of pnpm has no npm. pnpm view fetches from the registry on each call, so it needs no --prefer-online. A missing package fails with ERR_PNPM_FETCH_404, not E404.

Local checks:

  • actionlint, pnpm lint and pnpm format:check pass.
  • REVEAL_BROWSERS=chromium pnpm test: 635 tests passed, 28 skipped.
  • pnpm build and node scripts/smoke.mjs core pass.
  • The new pnpm view logic finds a published version, gives an empty current for a missing package, and stops on a registry that it cannot reach.

Check after the merge: dependabot-core reads devEngines.packageManager, but the update of a lockfile with a node@runtime: entry is not verified. Look at the next weekly npm PR.

Checklist

  • The PR targets the next branch.
  • The PR title follows Conventional Commits. A breaking change has ! and a BREAKING CHANGE: footer.
  • Tests cover the change. (Does not apply: this PR changes only the tool versions, CI and docs. The CI run of this PR checks the new setup.)
  • A change to an option, a default or an export also updates the READMEs, the consumer skills and the examples. (Does not apply: no opt 8000 ion, default or export changes.)

@morellodev
morellodev commented Oct 23, 2026
Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 23, 2026 •
edited
Loading
Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T13:42:35.708626Z 720ed4c Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 23, 2026
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: b78b417320

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@morellodev
morellodev commented Oct 23, 2026
Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 23, 2026
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 720ed4c012

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@morellodev
morellodev merged commit 202df0b into next Oct 23, 2026
19 checks passed
@morellodev
morellodev deleted the build/dev-engines branch October 23, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@morellodev
0