8000 fix(core): keep the reveal when `when` changes from true to null by morellodev · Pull Request #336 · awesome-reveal/awesome-reveal · GitHub
[go: up one dir, main page]
Skip to content

fix(core): keep the reveal when when changes from true to null - #336

Merged
morellodev merged 6 commits into
nextfrom
fix/keep-reveal-on-when-null
Oct 22, 2026
Merged

fix(core): keep the reveal when when changes from true to null#336
morellodev merged 6 commits into
nextfrom
fix/keep-reveal-on-when-null

Conversation

@morellodev
@morellodev morellodev commented Oct 22, 2026 •
edited
Loading
Copy link
Copy Markdown
Collaborator

Summary

A change of when from true to null hid a revealed element again. In view, the entrance played a second time and onReveal ran again. Below the fold, the element stayed hidden until the user scrolled to it.

Now null keeps the result of when: a revealed element stays revealed, and an element that false reset observes the viewport again.

Reduced motion had the same problem. It revealed the element but did not record the reveal. After the preference ended, a change of when to null or of threshold hid the element again. Now each reveal records its result, also at mount, at a change to reduced motion, and without Element.animate.

Checklist

  • The PR targets the next branch.
  • The PR title follows Conventional Commits. A breaking change has ! and a BREAKING CHANGE: footer.
  • Tests cover the change. (new contract scenarios: in view, below the fold, and after reduced motion ends)
  • A change to an option, a default or an export also updates the READMEs, the consumer skills and the examples. (READMEs, skills and JSDoc updated. The examples do not change, because the option set is the same.)

@morellodev
morellodev commented Oct 22, 2026
Copy link
Copy Markdown
Collaborator Author

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Oct 22, 2026
View reviewed changes
@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0cae40f0bd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/core/src/adapter.ts Resolved
@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 22, 2026 •
edited
Loading
Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T17:07:43.070807Z 1a9a4d2 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@morellodev
morellodev commented Oct 22, 2026
Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector
chatgpt-codex-conn 8000 ector Bot commented Oct 22, 2026
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: f703435fc3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@morellodev
morellodev commented Oct 22, 2026
Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 22, 2026
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 325250a932

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@morellodev
morellodev commented Oct 22, 2026
Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 22, 2026
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 3ec99dc28a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@morellodev
Merge remote-tracking branch 'origin/next' into fix/keep-reveal-on-wh…
1a9a4d2 
…en-null

# Conflicts:
#	packages/react/test/package/tree-shaking.test.ts
#	packages/vue/test/package/tree-shaking.test.ts
@morellodev
morellodev commented Oct 22, 2026
Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 22, 2026
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 1a9a4d22fa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@morellodev
morellodev merged commit a807df7 into next Oct 22, 2026
71 of 76 checks passed
@morellodev
morellodev deleted the fix/keep-reveal-on-when-null branch October 22, 2026 17:31
@morellodev morellodev mentioned this pull request Oct 22, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@morellodev
0