8000 fix: show focused content before hydration and during the entrance delay by morellodev · Pull Request #335 · awesome-reveal/awesome-reveal · GitHub
[go: up one dir, main page]
Skip to content

fix: show focused content before hydration and during the entrance delay - #335

Merged
morellodev merged 5 commits into
nextfrom
fix/show-focused-content
Oct 22, 2026
Merged

fix: show focused content before hydration and during the entrance delay#335
morellodev merged 5 commits into
nextfrom
fix/show-focused-content

Conversation

@morellodev
@morellodev morellodev commented Oct 22, 2026
Copy link
Copy Markdown
Collaborator

Summary

Focused content must be visible. Before this change, it stayed transparent in two cases:

  • Before hydration. The CSS hold of reveal.css kept server markup transparent for up to 5 s, also when it had focus. Now a :focus-within rule sets animation-duration: 0s on the hold. A change of duration keeps the start time, so a blur does not start a new hold. After the attach, the data-awesome-reveal-attached rule still hides the element, so when: false keeps its behavior.
  • During the entrance. Focus during the delay of a running entrance, or during the interval of a later cascade child, kept the content transparent until the entrance played. Now motions() listens to focusin and finishes the running animations. It uses finish(), so the finished promises resolve. An entrance that cannot finish, such as with duration: Infinity, is reported and cancelled.

Core and all the adapters use motions(), so both reveal/cascade and the adapter store get the fix. The size limits go up by about 200 B for core and about 300 B for each adapter bundle, CSS included.

Checklist

  • The PR targets the next branch.
  • The PR title follows Conventional Commits. A breaking change has ! and a BREAKING CHANGE: footer.
  • Tests cover the change. (contract, core and stylesheet tests in Chromium, Firefox and WebKit)
  • A change to an option, a default or an export also updates the READMEs, the consumer skills and the examples. (does not apply: no option, default or export changes. The READMEs describe the new focus behavior.)

@morellodev
morellodev commented Oct 22, 2026
Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 22, 2026 •
edited
Loading
Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T17:00:42.388518Z 5966c39 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 22, 2026
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 391e95dab2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@morellodev
morellodev commented Oct 22, 2026
Copy link
Copy Markdown
Collaborator Author

@codex review
8000

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 22, 2026
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 5966c399bd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@morellodev
morellodev merged commit 5fd14a9 into next Oct 22, 2026
19 checks passed
@morellodev
morellodev deleted the fix/show-focused-content branch October 22, 2026 17:03
@morellodev morellodev mentioned this pull request Oct 22, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@morellodev
0