Repository navigation
fix: ship types for moduleResolution node and a LICENSE in each package - #327
Merged
Merged
Conversation
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A user reported that a CRA-style tsconfig (
moduleResolution: "node",skipLibCheck) gives no type errors on<Reveal direction="up">orfrom="lft". That resolution mode ignoresexports. Core had notypesfield, so the adapter types that import from core becameany.typesand atypesVersionsentry for./adapter. React, Vue and compat get atypesVersionsentry for./reveal.css.check:packageruns attw with--ignore-rules cjs-resolves-to-esmin place of--profile esm-only. The old profile skipped the node10 and node16-from-CJS modes, so CI did not catch the bug. Now attw checks all four modes and ignores only the rule that the ESM-only design causes.LICENSE. npm adds a LICENSE file only from the package folder, so no tarball had the MIT text.describeDocsand the compat package test check that each copy is equal to the root file.vitest-browser-react,vitest-browser-vueandvue-tscmove to the pnpm catalog, because they are shared or have peers in the catalog.Checklist
nextbranch.!and aBREAKING CHANGE:footer.directionand"lft"errors.