8000 fix!: attach late React refs and report moved Astro tags by morellodev · Pull Request #314 · awesome-reveal/awesome-reveal · GitHub
[go: up one dir, main page]

Skip to content

fix!: attach late React refs and report moved Astro tags - #314

Merged
morellodev merged 4 commits into
nextfrom
fix/adapter-ref-and-tag-validation
Oct 15, 2026
Merged

morellodev merged 4 commits into
nextfrom
fix/adapter-ref-and-tag-validation

Conversation

@morellodev
@morellodev morellodev commented Oct 15, 2026 •
Copy link
Copy Markdown
Collaborator

Summary

React: the hooks now attach an element that a forwarded child mounts without another commit of the hook's component. The ref callback queues sync in a microtask, so the layout effect still applies the options of the same commit first.

Core: attach(null) followed by the same element replays the entrance only when null cancelled a running entrance. Before this change, React Suspense or Activity replayed a finished entrance each time it showed the element again.

Astro:

  • The RevealTag type accepts HTML tags and svg. It excludes document tags, table parts and SVG-only tags, because the HTML parser does not keep them inside the host.
  • The server render does not validate as. A throw there would fail the whole page, which the failure policy forbids.
  • The <awesome-reveal> element reports an error in the browser when the parser moved its tag out, for example a div in a <p>. Before, it failed silently.
  • The README and the skill warn about placement in <p>, tables and <select>.

Size budgets: the Astro client script limit goes from 4975 to 5150, React from 6600/6250 to 6700/6325, and Vue from 6100/5700 to 6175/5800. The error message and the replay check add the bytes. The imperative core budget does not change.

Validation: 702 unit, SSR and browser tests, 45 package tests, publint, attw, test type checks, lint and formatting passed. The React 18 job runs in CI only.

Checklist

  • The PR targets the next branch.
  • The PR title follows Conventional Commits. A breaking change has ! and a BREAKING CHANGE: footer.
  • Tests cover the change.
  • A change to an option, a default or an export also updates the READMEs, the consumer skills and the examples.

BREAKING CHANGE: The Astro RevealTag type accepts HTML tags and svg, without document tags, table parts and SVG-only tags. Reveal the containing table, or content inside a table cell, instead.

BREAKING CHANGE: Astro components reject document tags, table parts and select parts in the as prop. Reveal the containing table, select or content element instead.
BREAKING CHANGE: The Astro RevealTag type accepts HTML tags and svg, without document tags, table parts and SVG-only tags. The server render no longer validates as.
@morellodev morellodev changed the title fix!: handle late React refs and reject unsafe Astro tags fix!: attach late React refs and report moved Astro tags Oct 15, 2026
@morellodev
Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 15, 2026 •
Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T09:51:12.234417Z 20fc043 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 20fc043be2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/core/src/adapter.ts Resolved
@morellodev
morellodev merged commit 3160bcc into next Oct 15, 2026
18 checks passed
@morellodev
morellodev deleted the fix/adapter-ref-and-tag-validation branch October 15, 2026 10:01
@morellodev morellodev mentioned this pull request Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0