Repository navigation
fix!: attach late React refs and report moved Astro tags - #314
Merged
Merged
Conversation
BREAKING CHANGE: Astro components reject document tags, table parts and select parts in the as prop. Reveal the containing table, select or content element instead.
BREAKING CHANGE: The Astro RevealTag type accepts HTML tags and svg, without document tags, table parts and SVG-only tags. The server render no longer validates as.
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 20fc043be2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
React: the hooks now attach an element that a forwarded child mounts without another commit of the hook's component. The ref callback queues
syncin a microtask, so the layout effect still applies the options of the same commit first.Core:
attach(null)followed by the same element replays the entrance only whennullcancelled a running entrance. Before this change, React Suspense or Activity replayed a finished entrance each time it showed the element again.Astro:
RevealTagtype accepts HTML tags andsvg. It excludes document tags, table parts and SVG-only tags, because the HTML parser does not keep them inside the host.as. A throw there would fail the whole page, which the failure policy forbids.<awesome-reveal>element reports an error in the browser when the parser moved its tag out, for example adivin a<p>. Before, it failed silently.<p>, tables and<select>.Size budgets: the Astro client script limit goes from 4975 to 5150, React from 6600/6250 to 6700/6325, and Vue from 6100/5700 to 6175/5800. The error message and the replay check add the bytes. The imperative core budget does not change.
Validation: 702 unit, SSR and browser tests, 45 package tests, publint, attw, test type checks, lint and formatting passed. The React 18 job runs in CI only.
Checklist
nextbranch.!and aBREAKING CHANGE:footer.BREAKING CHANGE: The Astro
RevealTagtype accepts HTML tags andsvg, without document tags, table parts and SVG-only tags. Reveal the containing table, or content inside a table cell, instead.