8000 ci: default the release bump so a mobile dispatch can't send it empty by onsi · Pull Request #1688 · onsi/ginkgo · GitHub
[go: up one dir, main page]

Skip to content

ci: default the release bump so a mobile dispatch can't send it empty - #1688

Merged
onsi merged 1 commit into
masterfrom
worktree-fix-release-bump-input
Oct 9, 2026
Merged

onsi merged 1 commit into
masterfrom
worktree-fix-release-bump-input

Conversation

@onsi
@onsi onsi commented Oct 9, 2026
Copy link
Copy Markdown
Owner

The Release run on 2026-10-09 (37926712409) failed with usage: scripts/release.sh patch|minor because BUMP was empty. It was dispatched from the GitHub mobile app. The bump choice input had no default. The web UI submits the first option anyway, but the mobile app submitted nothing.

  • bump now has default: patch and required: true
  • A new check-inputs job validates the bump before the test workflow runs, so a bad input fails in seconds instead of after about 5 minutes
  • run-name: Release (<bump>) shows the bump in the runs list
  • Fixes the "aeveral" typo in the Unreleased changelog entry, which would otherwise appear in the release notes

🤖 Generated with Claude Code

https://claude.ai/code/session_01PHpCwq4zwCazRetYBgay4u

The bump choice input had no default.  The GitHub web UI submits the
first option anyway, but the mobile app dispatched the run with an empty
bump, which failed scripts/release.sh only after the full test run.

Default to patch, mark the input required, check it in a job that runs
before the tests, and put the bump in the run name.  Also fix a typo in
the Unreleased changelog entry.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PHpCwq4zwCazRetYBgay4u
@onsi
onsi marked this pull request as ready for review October 9, 2026 22:59
@onsi
onsi merged commit 9e02cad into master Oct 9, 2026
9 checks passed
@onsi
onsi deleted the worktree-fix-release-bump-input branch October 9, 2026 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0