Repository navigation
Implemented files_dropped_event for macOS - #619
Merged
Merged
Conversation
Owner
|
Thanks for PR! |
Contributor
Author
|
Thanks for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #568
Implemented the files_dropped_event for macOS. It's only triggered for files, not directories. Also returns the dropped_file_bytes same as for linux_x11.
On macOS this only required the implementation of two events :
We also need to tell the view to handle drag 'n drop with a call to registerForDraggedTypes. Without this, the drag 'n drop events are not triggered at all.
When files are dropped we read its bytes for dropped_file_bytes with std::fs::read. Mimicked this from linux_x11.rs.
Tested it on macOS Tahoe 26.4 (currently the latest macOS version) and on the older macOS Monterey 12.7.6.