Repository navigation
Some CoreGraphics functions are only available on macOS - #617
Merged
Merged
Conversation
Contributor
Author
|
@not-fl3 sorry for the PR spamming. Had some time on my hands. Figured I'd try to help out. You can also just ignore them 😄 |
Owner
|
Thanks for PR! I very much appreaciate your work, I do not have any Mac hardware, so without your PRs Mac bugs would never be fixed :) |
Contributor
Author
|
Thanks for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #561
Apple's CoreGraphics framework functions CGDisplayPixelsHigh and CGMainDisplayID are only available on macOS. They do not exist on iOS.
If you compile your miniquad code as a static library and link it to your iOS App, the build on Xcode fails with the following errors:
Undefined symbol: _CGDisplayPixelsHigh
Undefined symbol: _CGMainDisplayID
Linker command failed with exit code 1 (use -v to see invocation)
Modified framework.rs to make sure, they're only included on macOS.